Python files with invalid names are incorrectly handled

[sqlalchemy-bot]

Migrated issue, originally created by Sébastien Leblanc (@sebleblanc)

Emacs leaves backup files named .#name_of_my_python_file.py. It seems that Alembic will pick them up (as if it was looking for all files "*.py") but when it tries to load them the interpreter trips up because it is not a valid Python module name.

Alembic should validate the name of the module before attempting to load it, ignoring it if it its name is invalid.

  File "/home/sebleblanc/myproject/virtualenv/lib/python3.5/site-packages/alembic/util/pyfiles.py", line 87, in load_python_file
    raise ImportError("Can't find Python file %s" % path)
ImportError: Can't find Python file /home/sebleblanc/myproject/app/migrations/versions/.#fc57a0d49adc_leftover_file.py

[sqlalchemy-bot]

Changes by Sébastien Leblanc (@sebleblanc):

• edited description

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

there's an existing regexp that checks these, feel free to send a PR.

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• removed labels: feature
• added labels: bug

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

Ignore py files generated by emacs

Added a file ignore for Python files of the form .#<name>.py,
which are generated by the Emacs editor. Pull request courtesy
Markus Mattes.

Change-Id: I06861c2ba7b8e6730948c01ff0690b50bdb26f0f
Pull-request: zzzeek/alembic#32
Fixes: #356

→ 053062c

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• changed status to closed