Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop_index does not support postgresql_concurrently=True #424

Closed
sqlalchemy-bot opened this issue Mar 29, 2017 · 11 comments
Closed

drop_index does not support postgresql_concurrently=True #424

sqlalchemy-bot opened this issue Mar 29, 2017 · 11 comments

Comments

@sqlalchemy-bot
Copy link

@sqlalchemy-bot sqlalchemy-bot commented Mar 29, 2017

Migrated issue, originally created by Alex Plugaru (@sasha)

Seems create_index supports postgresql_concurrently=True, but not drop_index.

Related to #277

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Mar 29, 2017

Michael Bayer (@zzzeek) wrote:

i don't know that op.create_index() ever explicitly had any change for postgresql_concurrently, it just accepts kwargs whereas drop_index doesn't.

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Mar 29, 2017

Changes by Michael Bayer (@zzzeek):

  • added labels: op directives
@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Mar 29, 2017

Changes by Michael Bayer (@zzzeek):

  • set milestone to "fasttrack"
@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Aug 1, 2017

Alex Plugaru (@sasha) wrote:

I'd love to send a small PR for this, but I have no idea how to do it. How do you fork a repo here?

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Aug 1, 2017

Michael Bayer (@zzzeek) wrote:

it would need to support the option for both create_index and drop_index and have tests in tests/test_postgresql.py.

click the plus sign on far left and click "Fork"

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Aug 3, 2017

Michael Bayer (@zzzeek) wrote:

i have it up here: https://gerrit.sqlalchemy.org/465

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Aug 4, 2017

Michael Bayer (@zzzeek) wrote:

Add support for kw to DROP INDEX, test postgresql_concurrently

Change-Id: I89c98401d3e1f1252041b622e045c6dc85fa59a1
Fixes: #424

1011366

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Aug 4, 2017

Changes by Michael Bayer (@zzzeek):

  • changed status to closed
@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Aug 4, 2017

Michael Bayer (@zzzeek) wrote:

Add support for kw to DROP INDEX, test postgresql_concurrently

Change-Id: I89c98401d3e1f1252041b622e045c6dc85fa59a1
Fixes: #424

a893eb9

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Aug 4, 2017

Alex Plugaru (@sasha) wrote:

I tested locally just now and can confirm that it works.

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Aug 4, 2017

Alex Plugaru (@sasha) wrote:

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant