drop_index does not support postgresql_concurrently=True

[sqlalchemy-bot]

Migrated issue, originally created by Alex Plugaru (@sasha)

Seems create_index supports postgresql_concurrently=True, but not drop_index.

Related to #277

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

i don't know that op.create_index() ever explicitly had any change for postgresql_concurrently, it just accepts kwargs whereas drop_index doesn't.

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• added labels: op directives

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• set milestone to "fasttrack"

[sqlalchemy-bot]

Alex Plugaru (@sasha) wrote:

I'd love to send a small PR for this, but I have no idea how to do it. How do you fork a repo here?

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

it would need to support the option for both create_index and drop_index and have tests in tests/test_postgresql.py.

click the plus sign on far left and click "Fork"

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

i have it up here: https://gerrit.sqlalchemy.org/465

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

Add support for kw to DROP INDEX, test postgresql_concurrently

Change-Id: I89c98401d3e1f1252041b622e045c6dc85fa59a1
Fixes: #424

→ 1011366

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• changed status to closed

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

Add support for kw to DROP INDEX, test postgresql_concurrently

Change-Id: I89c98401d3e1f1252041b622e045c6dc85fa59a1
Fixes: #424

→ a893eb9

[sqlalchemy-bot]

Alex Plugaru (@sasha) wrote:

I tested locally just now and can confirm that it works.

[sqlalchemy-bot]

Alex Plugaru (@sasha) wrote:

Thank you!