-
-
Notifications
You must be signed in to change notification settings - Fork 268
drop_index does not support postgresql_concurrently=True #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Michael Bayer (@zzzeek) wrote: i don't know that op.create_index() ever explicitly had any change for postgresql_concurrently, it just accepts kwargs whereas drop_index doesn't. |
Changes by Michael Bayer (@zzzeek):
|
Changes by Michael Bayer (@zzzeek):
|
Alex Plugaru (@sasha) wrote: I'd love to send a small PR for this, but I have no idea how to do it. How do you fork a repo here? |
Michael Bayer (@zzzeek) wrote: it would need to support the option for both create_index and drop_index and have tests in tests/test_postgresql.py. click the plus sign on far left and click "Fork" |
Michael Bayer (@zzzeek) wrote: i have it up here: https://gerrit.sqlalchemy.org/465 |
Changes by Michael Bayer (@zzzeek):
|
Alex Plugaru (@sasha) wrote: I tested locally just now and can confirm that it works. |
Alex Plugaru (@sasha) wrote: Thank you! |
Migrated issue, originally created by Alex Plugaru (@sasha)
Seems
create_index
supportspostgresql_concurrently=True
, but notdrop_index
.Related to #277
The text was updated successfully, but these errors were encountered: