New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAIL tests/test_postgresql.py::PostgresqlOpTest::()::test_create_exclude_constraint_quoted_column #431
Comments
Sandro Tosi (@sandrotosi) wrote: that error goes away udpating to sqlalchemy 1.1.6, so maybe you should bump the requirements in setup.py to that version (or smth newer than the 0.7.6 currently there) |
Michael Bayer (@zzzeek) wrote: SQLAlchemy versions 0.7.X or so, through current, are supported. In this case you are hitting a bug that was repaired in 1.0.10, although the bug is not noted in the changelog (which is highly unusual). It was fixed in PR zzzeek/sqlalchemy#215. |
Changes by Michael Bayer (@zzzeek):
|
Michael Bayer (@zzzeek) wrote: (note the test in question is only supported for the 1.0.x series or higher) |
Michael Bayer (@zzzeek) wrote: if you could clarify for me your "build" where you need the test suite to run against an obsolete SQLAlchemy version, that would help. I can mark these tests with more specific "failing" in that case. |
Sandro Tosi (@sandrotosi) wrote: yeah but you dont check that! (and it's also not true as with 1.0.8 the bug is there only; so 1.0.x with x >= 10) you need to guard that check with the version of sqla: if it's lower than X (with X the minimum version where the test can success) then skip it |
Sandro Tosi (@sandrotosi) wrote: i was building alembic against the debian jessie backport version of sqlalchemy; while it is not the most up-to-date, according to the requirement versions, it is supported, so tests shouldnt fail if running against taht version |
Michael Bayer (@zzzeek) wrote: |
Changes by Michael Bayer (@zzzeek):
|
Sandro Tosi (@sandrotosi) wrote: nice!! thanks a ton for the super-fast fix! |
Changes by Michael Bayer (@zzzeek):
|
Migrated issue, originally created by Sandro Tosi (@sandrotosi)
Hello,
when building alembic 0.9.2 i got this error:
we're using sqlalchemy 1.0.8
The text was updated successfully, but these errors were encountered: