Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_repr_type conflates setting up imports with rendering #494

Closed
sqlalchemy-bot opened this issue May 18, 2018 · 3 comments
Closed

_repr_type conflates setting up imports with rendering #494

sqlalchemy-bot opened this issue May 18, 2018 · 3 comments

Comments

@sqlalchemy-bot
Copy link

@sqlalchemy-bot sqlalchemy-bot commented May 18, 2018

Migrated issue, originally created by Michael Bayer (@zzzeek)

if we defer to the dialect to render the type with impl.render_type(), we then only use that impl if the imports are within the "sqlalchemy.dialects" space. this makes no sense, why are we running impl.render_type() then ignoring it? seems like we are hoping that _user_autogenerate_prefix() is perhaps adding to the imports, and generally that's why we aren't just returning impl_rt. external dialects want the render_type() functionality as well.

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented May 18, 2018

Michael Bayer (@zzzeek) wrote:

Use external impl for type rendering

The render_type() method of DefaultImpl was hardcoded to
only work for SQLAlchemy types. Most of the work here involves
adding a proof of concept suite illustrating an external dialect
fully rendering types and nested types with imports.

Change-Id: Ia1bf7bad85efdc6083388e724601d5501f5e2454
Fixes: #494

b702e05

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented May 18, 2018

Changes by Michael Bayer (@zzzeek):

  • changed status to closed
@sqlalchemy-bot sqlalchemy-bot added this to the fasttrack milestone Nov 27, 2018
vvvrrooomm pushed a commit to vvvrrooomm/alembic that referenced this issue Jan 10, 2019
The render_type() method of DefaultImpl was hardcoded to
only work for SQLAlchemy types.  Most of the work here involves
adding a proof of concept suite illustrating an external dialect
fully rendering types and nested types with imports.

Change-Id: Ia1bf7bad85efdc6083388e724601d5501f5e2454
Fixes: sqlalchemy#494
vvvrrooomm pushed a commit to vvvrrooomm/alembic that referenced this issue Jan 10, 2019
The render_type() method of DefaultImpl was hardcoded to
only work for SQLAlchemy types.  Most of the work here involves
adding a proof of concept suite illustrating an external dialect
fully rendering types and nested types with imports.

Change-Id: Ia1bf7bad85efdc6083388e724601d5501f5e2454
Fixes: sqlalchemy#494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant