Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "force" parameter from identifierpreparer.quote, quote_schema in alembic/ddl/base.py #528

Closed
zzzeek opened this Issue Jan 17, 2019 · 9 comments

Comments

Projects
None yet
4 participants
@zzzeek
Copy link
Member

zzzeek commented Jan 17, 2019

The "force" parameter has had no effect since 0.9 and I was going to remove it entirely in 1.3, though at the moment I'm going to just have it emit a deprecation warning. this will still cause alembic's tests to fail on the warning.

@ParthS007

This comment has been minimized.

Copy link
Contributor

ParthS007 commented Jan 29, 2019

Hi @zzzeek
Can I work on this Issue?

@mikeywaites

This comment has been minimized.

Copy link
Member

mikeywaites commented Jan 29, 2019

@ParthS007 I did make a start but work totally anhilated me last week. I was hoping to sit down tonight and work on it some more.

More than happy if you wanna pick it up though, I didn't get far.

@ParthS007

This comment has been minimized.

Copy link
Contributor

ParthS007 commented Jan 29, 2019

okay, I will work on this. 👍
I have to remove force=None parameter from here.
Am I getting this right? If not can you please help me getting started with this issue?
Thanks for the quick reply.

@mikeywaites

This comment has been minimized.

Copy link
Member

mikeywaites commented Jan 29, 2019

Yes, having looked at this again I can confirm that's correct. the force param will now result in alembic's test suite to fail so we just want that removed. I can see one place this is happening that @zzzeek has already pointed out.

Give the test suite a run once it's removed and you should be good to go. Not sure why I thought there was more to it than this but hey, thanks for picking this up anyway, the help is really appreciated @ParthS007

@ParthS007

This comment has been minimized.

Copy link
Contributor

ParthS007 commented Jan 30, 2019

@mikeywaites I have made the Pull Request. Please review and let me know your views on it. 😃

@mikeywaites

This comment has been minimized.

Copy link
Member

mikeywaites commented Feb 4, 2019

@ParthS007 Sorry i've been slow on this. Will take a look later on today and get this reviewed.

@sqla-tester

This comment has been minimized.

Copy link
Collaborator

sqla-tester commented Feb 4, 2019

Parth Shandilya has proposed a fix for this issue in the master branch:

Fixes#528: Removed Force Parameter from Base.py https://gerrit.sqlalchemy.org/1125

@sqla-tester

This comment has been minimized.

Copy link
Collaborator

sqla-tester commented Feb 20, 2019

Parth Shandilya has proposed a fix for this issue in the master branch:

Removed force parameter from base.py https://gerrit.sqlalchemy.org/1125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.