Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
the autogenerate renderer should escape the quotes in the SQL comments #529
I use recent versions of SQLAlchemy and alembic in order to insert some comments on columns and tables (cf. https://gerrit.sqlalchemy.org/#/c/sqlalchemy/alembic/+/932/).
When I add a column with a comment to a table in my SQLAlchemy schema, the autogenerate feature fails to load the Python migration script due to a single quote (in my comment). I've got a syntax error since the result of the renderer is malformed.
artist = Table( "artist", metadata, Column("id", Integer, primary_key=True), Column("name", String, nullable=False, comment="artist name"), # added this column with a single quote in the comment Column("band", String, comment="Artist's band") )
I think the renderer should escape the single quotes, e.g. here https://github.com/sqlalchemy/alembic/blob/master/alembic/autogenerate/render.py#L617
I can replace the
In my case, I write the comments in French. So I've a lot of apostrophes!
I'll submit a PR. I would like to share with you the best way to fix that.