Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 2to3 dependency #55

Closed
sqlalchemy-bot opened this issue Jun 23, 2012 · 15 comments
Closed

remove 2to3 dependency #55

sqlalchemy-bot opened this issue Jun 23, 2012 · 15 comments

Comments

@sqlalchemy-bot
Copy link

@sqlalchemy-bot sqlalchemy-bot commented Jun 23, 2012

Migrated issue, originally created by Michael Bayer (@zzzeek)

includes:

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Dec 9, 2012

Changes by Michael Bayer (@zzzeek):

  • removed labels: bug
  • added labels: task
@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Apr 8, 2013

Hong Minhee (@dahlia) wrote:

I want to work on this, but I need to ask a question to @zzzeek first: could we introduce tox into Alembic for cross-VM testing?

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Apr 8, 2013

Michael Bayer (@zzzeek) wrote:

using tox just means you have an .ini file there right? we don't need it for continuous integration, if you see here we just have separate jenkins builds per platform. you can just use the .ini locally ?

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Apr 8, 2013

Hong Minhee (@dahlia) wrote:

I meant, do you mind if I add tox.ini file into the source tree?

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Apr 8, 2013

Hong Minhee (@dahlia) wrote:

Or should I add tox.ini into .hgignore list?

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Apr 8, 2013

Michael Bayer (@zzzeek) wrote:

if/until I totally get into tox for sqlalchemy and everything, put it in .hgignore would be better for now

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Apr 8, 2013

Hong Minhee (@dahlia) wrote:

Okay, and one more question: SQLAlchemy 0.8 currently supports Python 2.5–3.3, so is it the same for Alembic?

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Apr 8, 2013

Hong Minhee (@dahlia) wrote:

@zzzeek It currently seems impossible to be parsed on Python 2.5. Does not Alembic support Python 2.5?

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Apr 8, 2013

Michael Bayer (@zzzeek) wrote:

lack of 2.5 is not official but that's how it seems, sure. 2.5 is gone very soon in sqlalchemy too (django already dropped 2.5).

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Apr 10, 2013

Hong Minhee (@dahlia) wrote:

If we don’t need to support 2.5, is there still any reason to use except Exception: e = sys.exc_info()[1] instead of simply except Exception as e:?

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Apr 10, 2013

Michael Bayer (@zzzeek) wrote:

no, let's go with 2.6 idioms all the way. we'll need to add an explicit message to the docs that 2.6 is required.

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Apr 12, 2013

Hong Minhee (@dahlia) wrote:

I’ve just opened the pull request #34, could you review it?

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Apr 12, 2013

Michael Bayer (@zzzeek) wrote:

left some comments...

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Apr 13, 2013

Michael Bayer (@zzzeek) wrote:

came out great. thanks a ton ! will call this version 0.6.0.

@sqlalchemy-bot
Copy link
Author

@sqlalchemy-bot sqlalchemy-bot commented Jun 7, 2013

Changes by Michael Bayer (@zzzeek):

  • changed status to closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.