Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more regressions with type comaprisons #671

Closed
zzzeek opened this issue Mar 19, 2020 · 3 comments
Closed

more regressions with type comaprisons #671

zzzeek opened this issue Mar 19, 2020 · 3 comments

Comments

@zzzeek
Copy link
Member

@zzzeek zzzeek commented Mar 19, 2020

this comaprison should return no change, because "Unicode" is the generic type:


diff --git a/tests/test_autogen_diffs.py b/tests/test_autogen_diffs.py
index e1e5c8d..7fa4465 100644
--- a/tests/test_autogen_diffs.py
+++ b/tests/test_autogen_diffs.py
@@ -795,6 +795,8 @@ class CompareMetadataToInspectorTest(TestBase):
         (Unicode(32), VARCHAR(32), False, config.requirements.unicode_string),
         (VARCHAR(6), VARCHAR(12), True),
         (VARCHAR(6), String(12), True),
+        (mysql.VARCHAR(200, charset='utf8'), Unicode(200), False, ),
+        (String(255, collation='utf8_bin'), String(255), False)
     )
     def test_string_comparisons(self, cola, colb, expect_changes):
         is_(self._compare_columns(cola, colb), expect_changes)

@pbecotte
Copy link
Collaborator

@pbecotte pbecotte commented Mar 19, 2020

Looks like you removed the config.requirements.mysql line from those two tests?

When I run it that way the VARCHAR/UNICODE test passes, but the String one fails with

psycopg2.errors.UndefinedObject) collation "utf8_bin" for encoding "UTF8" does not exist
(sqlite3.OperationalError) no such collation sequence: utf8_bin

Are you getting a different result? I updated off of master and ran against postgres/mysql/oracl/sqlite

@zzzeek
Copy link
Member Author

@zzzeek zzzeek commented Mar 19, 2020

the version I just released should have those tests qualified with "mysql required", it passed on CI for all backends: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/1802

i put the wrong change number into it,drat

@zzzeek
Copy link
Member Author

@zzzeek zzzeek commented Mar 19, 2020

tox -e py37-sqlite-postgresql-mysql -- tests/test_autogen_diffs.py

passes for me from latest master....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants