Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create set of specific "suite" tests suitable for testing with third-party dialects #855

Closed
gordthompson opened this issue Jun 8, 2021 · 3 comments
Assignees
Milestone

Comments

@gordthompson
Copy link
Member

Is your feature request related to a problem? Please describe.
Alembic lacks a set of specific "suite" tests similar to what SQLAlchemy has for supporting third-party dialects.

Describe the solution you'd like
Create such a test suite, presumably in "alembic/testing/suite". Ensure that those tests are visible from a normal pip install alembic.

Describe alternatives you've considered
It is possible to run all of the current tests from the Alembic source tree, but that includes many tests that are either strictly internal to Alembic or address idiosyncrasies of the SQLA internal dialects (SQLite, Oracle, etc.).

First steps
Review current Alembic tests and identify candidates for inclusion in the "suite" tests, specifically those that are not

  • testing Alembic internals (database-agnostic), or
  • testing some esoteric behaviour for one of the SQLA internal dialects.
@gordthompson gordthompson added the requires triage New issue that requires categorization label Jun 8, 2021
@zzzeek zzzeek added feature test suite and removed requires triage New issue that requires categorization labels Jun 8, 2021
@sqla-tester
Copy link
Collaborator

Gord Thompson has proposed a fix for this issue in the master branch:

Implement "test suite" (WIP) https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/2867

@gordthompson gordthompson self-assigned this Jun 8, 2021
@gordthompson
Copy link
Member Author

Okay, with the current Alembic mods in …

https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/2867

… I've gotten the tests to run from within a sqlalchemy-cockroachdb source tree:

https://github.com/gordthompson/sqlalchemy-cockroachdb/tree/alembic_suite

I moved "test_op.py" into the Alembic suite because it was one of the tests that tripped up the CrDB dialect and therefore provided the opportunity to work around the issues

https://github.com/gordthompson/sqlalchemy-cockroachdb/blob/alembic_suite/test/test_suite_alembic.py

So now I guess we need to decide what other Alembic tests we want to move from "local" tests to "suite" tests. Any suggestions, @zzzeek ?

@zzzeek
Copy link
Member

zzzeek commented Jun 9, 2021

OK so that's great, good start, so what we need to do here and I will help, is identify "backend" tests and also write new ones that only exercise things the DB impl needs.

@zzzeek zzzeek added this to the 1.7 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants