Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheels are createed with py2.py3 compatibility tag #893

Closed
layday opened this issue Aug 30, 2021 · 7 comments
Closed

Wheels are createed with py2.py3 compatibility tag #893

layday opened this issue Aug 30, 2021 · 7 comments
Labels
bug Something isn't working installation

Comments

@layday
Copy link
Contributor

layday commented Aug 30, 2021

Alembic > 1.7 does not support Python 2, but wheels are created with the py2.py3 compatibility tag in the filename, declaring compatibility with Python 2.

@layday layday added the requires triage New issue that requires categorization label Aug 30, 2021
layday added a commit to layday/alembic that referenced this issue Aug 30, 2021
Since this project no longer supports Python < 3.6, wheels should
not be created with the "py2.py3" tag in their filename.

Fixes: sqlalchemy#893
@zzzeek
Copy link
Member

zzzeek commented Aug 30, 2021

great, are you sending a PR ?

@zzzeek zzzeek added bug Something isn't working installation and removed requires triage New issue that requires categorization labels Aug 30, 2021
@zzzeek
Copy link
Member

zzzeek commented Aug 30, 2021

see it, thanks

@CaselIT
Copy link
Member

CaselIT commented Aug 30, 2021

Does py2 try to install it, or its still blocked by the python_version constraint?

Asking to check if we need to release a 1.7.1 and yank 1.7 or not

@zzzeek
Copy link
Member

zzzeek commented Aug 30, 2021

i deleted the univresal wheel file from pypi and manually put up a py3 only wheel so there's no rush on this

@sqla-tester
Copy link
Collaborator

layday has proposed a fix for this issue in the master branch:

Do not tag wheel as being compatible with Python 2 https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/3031

@CaselIT
Copy link
Member

CaselIT commented Aug 30, 2021

I did not remember that files could be deleted from pypi

@zzzeek
Copy link
Member

zzzeek commented Aug 30, 2021

they can only be deleted "forever", meaning they can't be replaced. this is the one situation where we dont actually have to replace it, so it works .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working installation
Projects
None yet
Development

No branches or pull requests

4 participants