DeprecationWarning: inspect.getargspec() is deprecated

[sqlalchemy-bot]

Migrated issue, originally created by Randy Barlow (bowlofeggs)

Greetings!

In Python 3.6, I see a few warnings like this:

  /usr/local/lib/python3.6/site-packages/dogpile/cache/util.py:31: DeprecationWarning: inspect.getargspec() is deprecated, use inspect.signature() or inspect.getfullargspec()
    args = inspect.getargspec(fn)

[sqlalchemy-bot]

Michael Bayer (zzzeek) wrote:

OK....it was formatargspec that I had to vendor in SQLAlchemy, getargspec is easier as they have thankfully not deprecated getfullargspec().

the code that codes into dogpile/util/compat.py looks like:

#!python

if py3k:
    ArgSpec = collections.namedtuple("ArgSpec",
                                     ["args", "varargs", "keywords", "defaults"])

    from inspect import getfullargspec as inspect_getfullargspec

    def inspect_getargspec(func):
        return ArgSpec(
            *inspect_getfullargspec(func)[0:4]
        )
else:
    from inspect import getargspec as inspect_getfullargspec
    inspect_getargspec = inspect_getfullargspec

[zzzeek]

this got lost, can't believe i havent gotten all these yet across the three projects

[sqlalchemy-bot]

Mike Bayer has proposed a fix for this issue:

Fix all Py3k deprecation warnings https://gerrit.sqlalchemy.org/1002

[zzzeek]

fix did not pass all tests when master ran. ci for gerrit is apparently not resetting enough

[sqlalchemy-bot]

Mike Bayer has proposed a fix for this issue:

Fix all Py3k deprecation warnings https://gerrit.sqlalchemy.org/1006