Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect.getfullargspec() is deprecated in python 3.8 #154

Closed
zzzeek opened this issue May 16, 2019 · 6 comments
Closed

inspect.getfullargspec() is deprecated in python 3.8 #154

zzzeek opened this issue May 16, 2019 · 6 comments

Comments

@zzzeek
Copy link
Member

@zzzeek zzzeek commented May 16, 2019

see sqlalchemy/sqlalchemy#4674 as well as mako, alembic. basically everything

@zzzeek
Copy link
Member Author

@zzzeek zzzeek commented May 16, 2019

geargspec is used for:

  • the default function_key_generator

@4383
Copy link
Collaborator

@4383 4383 commented May 17, 2019

I'll take a look on my side

@zzzeek
Copy link
Member Author

@zzzeek zzzeek commented May 17, 2019

they say they are no longer deprecating it. however they still want to, and also the implelementaiton in python 3.6+ is much slower than it used to be, so I am considering vendoring a simple getfullargspec() into all my libraries, from the python 3.3 version.

@4383
Copy link
Collaborator

@4383 4383 commented May 17, 2019

Yeah I saw that...

https://docs.python.org/3.8/library/inspect.html#inspect.getfullargspec

$ python3.8 ~/dev/testinspect.py  # who use getfullargspec...
ArgSpec(args=['bim', 'bam', 'boom'], varargs=None, keywords=None, defaults=(True, 1))

It work with python 3.8 and getfullargspec

@4383
Copy link
Collaborator

@4383 4383 commented May 17, 2019

I think vendoring a simple getfullargspec is a good idea, as you sayed we can inspire from funcsigs and start to use signature from python 3.2 or something like that

@sqla-tester
Copy link
Collaborator

@sqla-tester sqla-tester commented May 29, 2019

Mike Bayer has proposed a fix for this issue in the master branch:

Use vendored getfullargspec() https://gerrit.sqlalchemy.org/1289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants