inspect.getfullargspec() is deprecated in python 3.8

[zzzeek]

see sqlalchemy/sqlalchemy#4674 as well as mako, alembic. basically everything

[zzzeek]

geargspec is used for:

• the default function_key_generator

[4383]

I'll take a look on my side

[zzzeek]

they say they are no longer deprecating it. however they still want to, and also the implelementaiton in python 3.6+ is much slower than it used to be, so I am considering vendoring a simple getfullargspec() into all my libraries, from the python 3.3 version.

[4383]

Yeah I saw that...

https://docs.python.org/3.8/library/inspect.html#inspect.getfullargspec

$ python3.8 ~/dev/testinspect.py  # who use getfullargspec...
ArgSpec(args=['bim', 'bam', 'boom'], varargs=None, keywords=None, defaults=(True, 1))

It work with python 3.8 and getfullargspec

[4383]

I think vendoring a simple getfullargspec is a good idea, as you sayed we can inspire from funcsigs and start to use signature from python 3.2 or something like that

[sqla-tester]

Mike Bayer has proposed a fix for this issue in the master branch:

Use vendored getfullargspec() https://gerrit.sqlalchemy.org/1289