-
Notifications
You must be signed in to change notification settings - Fork 48
dogpile.cache 1.1.0 fails to serialize on pypy3.6 7.3.2 #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
that's weird it's like the pickle.dumps() function is accepting two arguments ? not sure how all our tests pass if it's got a problem like that. |
i dont see in your above test where "region" is coming from , can you show that please? backend etc. |
Oops I missed those lines when copying, I updated the example |
does not fail w/ cpython 3.8!! weeeeeird |
i bet this has to do w/ cpickle vs pickle |
in pypy 3.6.9 I get this:
still looks like non-cpickle stuff |
alrighty, here it is:
pypy turning it into a method, likely because it's pure python pickle. |
Mike Bayer has proposed a fix for this issue in the master branch: apply staticmethod() to pickle.dumps/loads as class variables https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/2378 |
let me know if you can run dogpile.cache master through your use case testing or not, in case there are more regressions we can find. otherwise I can just release with what we have. |
master passes the PyPy CI testing I have, thanks |
ok let's release |
Full reproducer using docker:
I couldn't find where
serializer
gets assigned to find out what is happeningThe text was updated successfully, but these errors were encountered: