New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name not set for CacheRegion #27

Closed
sqlalchemy-bot opened this Issue Apr 14, 2013 · 7 comments

Comments

Projects
None yet
1 participant
@sqlalchemy-bot

sqlalchemy-bot commented Apr 14, 2013

Migrated issue, originally created by Wichert Akkerman (wichert)

The documentation for CacheRegion states that the name parameter is set on the caching region. The constructor forgets to do that though, leaving the region without a cache attribute.

@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Apr 14, 2013

Michael Bayer (zzzeek) wrote:

any chance I can get a quick pullreq on this one?

@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Apr 14, 2013

Wichert Akkerman (wichert) wrote:

If you were using git I would have sent one, but I'm afraid I've never used mercurial.

@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Apr 14, 2013

Michael Bayer (zzzeek) wrote:

if it were BZR I'd understand :) ... though the mercurial flow here is pretty much identical to git.... if bitbucket would allow me to swap the repo i could do that for the dogpile products, since im generally defaulting to git now.

@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Apr 14, 2013

Wichert Akkerman (wichert) wrote:

I think I have git-remote-hg working (included as contrib script with git) on my laptop, I could give that a try to make a pull request tonight. Might also be a useful tool if you want to convert at some point.

@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Apr 19, 2013

Michael Bayer (zzzeek) wrote:

b005b95 thanks again

@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Apr 19, 2013

Changes by Michael Bayer (zzzeek):

  • changed status to closed
@sqlalchemy-bot

This comment has been minimized.

sqlalchemy-bot commented Jun 21, 2013

Michael Bayer (zzzeek) wrote:

Set the name on the CacheRegion. Fixes #27

b005b95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment