Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow ssl to be enabled for redis #221

Closed
wants to merge 1 commit into from
Closed

allow ssl to be enabled for redis #221

wants to merge 1 commit into from

Conversation

pimbeenes
Copy link

No description provided.

@zzzeek zzzeek requested a review from sqla-tester June 9, 2022 17:52
Copy link
Collaborator

@sqla-tester sqla-tester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 26c6cc9 of this pull request into gerrit so we can run tests and reviews and stuff

@sqla-tester
Copy link
Collaborator

New Gerrit review created for change 26c6cc9: https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/3916

Copy link
Member

@zzzeek zzzeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no docs here on how to use this, but looking at https://redis-py.readthedocs.io/en/stable/connections.html#generic-client, there's all of these ssl arguments:

ssl=False, ssl_keyfile=None, ssl_certfile=None, ssl_cert_reqs='required', ssl_ca_certs=None, ssl_ca_path=None, ssl_ca_data=None, ssl_check_hostname=False, ssl_password=None, ssl_validate_ocsp=False, ssl_validate_ocsp_stapled=False, ssl_ocsp_context=None, ssl_ocsp_expected_cert=None, 

don't you need all of those for this to be useful?

I think a better implementation here would be that we take everything in "arguments" and pass it along to redis, or at the very least, we use a list of params to do it.

this is already in gerrit so I'll just add it

@sqla-tester
Copy link
Collaborator

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/dogpile.cache/+/3916 has been merged. Congratulations! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants