module_directory not handled properly when given an absolute template path on Windows

[sqlalchemy-bot]

Migrated issue, originally created by Anonymous

When an absolute path is given on windows (i.e. c:\ or d:) for the filename parameter to Template.init, then the module_directory parameter is ignored because of how os.path.join works.

A patch is attached to emulate the way absolute paths work on posix systems.

---

Attachments: win32fix.diff

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

I'd prefer this:

Index: mako/template.py
===================================================================
--- mako/template.py    (revision 473)
+++ mako/template.py    (working copy)
@@ -57,7 +57,9 @@
             self.uri = uri
         elif filename:
             self.module_id = re.sub(r'\W', "_", filename)
-            self.uri = filename
+            drive, path = os.path.splitdrive(filename)
+            path = os.path.normpath(path).replace(os.path.sep, "/")
+            self.uri = path
         else:
             self.module_id = "memory:" + hex(id(self))
             self.uri = self.module_id
@@ -95,8 +97,8 @@
                     u = u[1:]
                 path = os.path.abspath(
                         os.path.join(
-                            module_directory.replace('/', os.path.sep), 
-                            u + ".py"
+                            os.path.normpath(module_directory), 
+                            os.path.normpath(u) + ".py"
                             )
                         )
             else:

can you test ? This should have a platform independent unit test in order to be committed (i.e. set os.path to os.ntpath, check desired output, set os.path to os.posixpath, etc.).

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• set milestone to "0.3"

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

89eae3c

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• changed status to closed