Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra not passed to setup() #148

Closed
sqlalchemy-bot opened this issue Sep 6, 2010 · 7 comments
Closed

extra not passed to setup() #148

sqlalchemy-bot opened this issue Sep 6, 2010 · 7 comments
Labels
bug Something isn't working installation low priority
Milestone

Comments

@sqlalchemy-bot
Copy link

Migrated issue, originally created by Anonymous

setup.py's setup is missing "**extra" (for Python 3 installations)

Index: mako-0.3.4/setup.py
===================================================================
--- mako-0.3.4.orig/setup.py
+++ mako-0.3.4/setup.py
@@ -64,4 +64,5 @@ ties to Python calling and scoping seman
       [babel.extractors]
       mako = mako.ext.babelplugin:extract
       """,
+      **extra
 )
@sqlalchemy-bot
Copy link
Author

Anonymous wrote:

The reason this is needed for python3 installations is that extra holds the value use_2to3: "True". If this is not added to the call to setup() then setup.py does not run 2to3 to convert the source tree to python3 syntax.

@sqlalchemy-bot
Copy link
Author

Michael Bayer (@zzzeek) wrote:

no argument there, this unfortunately forgot to get included in the recent release.

@sqlalchemy-bot
Copy link
Author

Changes by Michael Bayer (@zzzeek):

  • removed labels: easy

@sqlalchemy-bot
Copy link
Author

Changes by Michael Bayer (@zzzeek):

  • set milestone to "0.3.5"

@sqlalchemy-bot
Copy link
Author

Changes by Michael Bayer (@zzzeek):

  • changed milestone from "0.3.5" to "0.3.6"

@sqlalchemy-bot
Copy link
Author

Michael Bayer (@zzzeek) wrote:

ec3256d

@sqlalchemy-bot
Copy link
Author

Changes by Michael Bayer (@zzzeek):

  • changed status to closed

@sqlalchemy-bot sqlalchemy-bot added this to the 0.3.6 milestone Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working installation low priority
Projects
None yet
Development

No branches or pull requests

1 participant