Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to UTF-8 encoding #267

Closed
sqlalchemy-bot opened this issue Aug 24, 2017 · 5 comments
Closed

Default to UTF-8 encoding #267

sqlalchemy-bot opened this issue Aug 24, 2017 · 5 comments
Labels
feature lexer
Milestone
1.1

Comments

@sqlalchemy-bot
Copy link

sqlalchemy-bot commented Aug 24, 2017

Migrated issue, originally created by Anthony Sottile (@asottile)

In line with PEP-3120
@sqlalchemy-bot
Copy link
Author

sqlalchemy-bot commented Aug 25, 2017

Michael Bayer (@zzzeek) wrote:

we'd likely need a .y release (e.g. 1.1) for a change like that. mako is lacking a dedicated maintainer at the moment so I can't provide any ETA on a potential 1.1.

@sqlalchemy-bot
Copy link
Author

sqlalchemy-bot commented Aug 25, 2017

Changes by Michael Bayer (@zzzeek):

  • added labels: lexer

@sqlalchemy-bot
Copy link
Author

sqlalchemy-bot commented Aug 25, 2017

Changes by Michael Bayer (@zzzeek):

  • set milestone to "1.1"

@sqlalchemy-bot sqlalchemy-bot added this to the 1.1 milestone Nov 26, 2018
@zzzeek
Copy link
Member

zzzeek commented May 29, 2020 •
edited

this needs to be done. see sqlalchemy/alembic#701

@sqla-tester
Copy link
Collaborator

sqla-tester commented May 29, 2020

Mike Bayer has proposed a fix for this issue in the master branch:

Switch template encoding to utf-8 https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature lexer
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
3 participants
@zzzeek @sqla-tester @sqlalchemy-bot