QuestDB: add types, seek to extend code to find issues in QuestDB #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrigger
reviewed
Jun 12, 2023
| @@ -35,11 +35,11 @@ private enum Action { | |||
|
|
|||
| AUTOCOMMIT("autocommit", (r) -> 1, Scope.GLOBAL, Scope.SESSION), // | |||
| BIG_TABLES("big_tables", (r) -> Randomly.fromOptions("OFF", "ON"), Scope.GLOBAL, Scope.SESSION), // | |||
| COMPLETION_TYPE("completion_type", (r) -> Randomly.fromOptions("'NO_CHAIN'", "'CHAIN'", "'RELEASE'", 0, 1, 2), | |||
| COMPLETION_TYPE("completion_type", (r) -> Randomly.fromOptions("'NO_CHAIN'", "'CHAIN'", "'RELEASE'", "0", "1", "2"), | |||
There was a problem hiding this comment.
What's the motivation for these changes? Any IDE warning or so?
There was a problem hiding this comment.
hi! yes, warnings in intelliJ. I will resume with the PR soon, another priority kicked in :), you know how these things are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started playing with the QuestDB kit inside of SQLancer.
At present I am adding tests and I am trying to get my had around of the messages I get when I execute:
My goal is to improve this draft until I feel confident enough to make it into an official PR.
Any early feedback is appreciated.
Note: I will reformat the code at the end. At present I use intellij and it is configured as per QuestDB standards. I will make the code affected by this PR have the same style as the rest of the codebase.