New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email submission #536

Open
potatoqualitee opened this Issue Aug 24, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@potatoqualitee
Copy link
Member

potatoqualitee commented Aug 24, 2018

Couple of DBAChecks improvement ideas:

1. If it encounters a job that has not completed successfully (i.e. it failed, or was cancelled), then a further check is made to see if the job is now running, and thus not highlighting it as being an error.

An example of such a job might be a Replication agent job which was cancelled, then retried successfully, and is now running.

2. Have a configuration to allow offline databases to be excluded from certain checks.

I love DBAChecks, BTW!
@wsmelton

This comment has been minimized.

Copy link
Member

wsmelton commented Aug 26, 2018

If it encounters a job that has not completed successfully (i.e. it failed, or was cancelled), then a further check is made to see if the job is now running, and thus not highlighting it as being an error.

This sounds more like trying to turn dbachecks into a monitoring tool, which it is not. This would be purely based on how often you are running dbachecks itself as to whether this would be relevant.

@SQLDBAWithABeard

This comment has been minimized.

Copy link
Collaborator

SQLDBAWithABeard commented Aug 26, 2018

I'm conflicted about number 1 - need to mull it over. It is not a monitoring tool but it is used as a post-refresh, post-maintenance status check where that could be useful

@SQLDBAWithABeard

This comment has been minimized.

Copy link
Collaborator

SQLDBAWithABeard commented Aug 26, 2018

Number 2 I agree

@wsmelton

This comment has been minimized.

Copy link
Member

wsmelton commented Aug 26, 2018

Well I guess it is a legitimate check to see a failure count on a job that runs frequently.

So to check in the description given you could just have a config for consecutive failures before a job gets flagged. Then even if the jobs last run was failure and the current state is running is irrelevant.

@SQLDBAWithABeard

This comment has been minimized.

Copy link
Collaborator

SQLDBAWithABeard commented Sep 5, 2018

Number 2 is completed with @jpomfret recent improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment