Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Checks Failing on Non-Readable Secondaries #611

Open
kylejdoyle opened this Issue Mar 26, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@kylejdoyle
Copy link

kylejdoyle commented Mar 26, 2019

The LogfileCount, FileGroupBalanced, and DatafileAutoGrowthType checks are failing on non-readable secondaries. Something like -and ($Psitem.IsAccessible -eq $true) needs to be added to all of these checks in the Databases.Tests.ps1 on lines 535, 615, and 730.

@shaneis

This comment has been minimized.

Copy link
Collaborator

shaneis commented Mar 26, 2019

So you found the error, troubleshooted it, figured out a fix, and created an issue.

I'd personally love to see a PR as well :)

If not let us know, we can create one or throw it up to "good-first-issue" label

@wsmelton

This comment has been minimized.

Copy link
Member

wsmelton commented Mar 27, 2019

Check #432 as this is already done for some checks...

@kylejdoyle

This comment has been minimized.

Copy link
Author

kylejdoyle commented Mar 28, 2019

Will do, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.