Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fix #805

Merged
merged 6 commits into from Nov 23, 2020
Merged

Doc fix #805

merged 6 commits into from Nov 23, 2020

Conversation

Ant-Green
Copy link
Contributor

A New PR

THANK YOU - We love to get PR's and really appreciate your time and help to improve this module

Accepting a PR

Before we accept the PR - please confirm that you have run the tests locally to avoid our automated build and release process failing. You can see how to do that in our wiki

https://github.com/sqlcollaborative/dbachecks/wiki

Please confirm you have 0 failing Pester Tests

[] There are 0 failing Pester tests

Changes this PR brings

Please add below the changes that this PR covers. It doesnt need an essay just the bullet points :-)

Docs needed changed to detail to install Pester 4.10.0 manually as its no longer installed by the gallery get.

Also seems to have pulled my other branches in with it also.

Ant-Green and others added 6 commits July 23, 2020 09:36
For some reason my fork wouldnt update from origin development and causing issues.
Deleted and started a fresh.
DuplicateIndex Check - Added new configuration option to allow people to filter out databases, as SSRS DB's have duplicate indexes and names are configuration in older versions, defaults to ReportServer & ReportServerTempDB

GuestUserConnect - Changes method to Get-Database instead of InstanceSMO so its easier to filter out none accessable databases as the check would report false positives for offline or restoring databases

NotExpectedTraceFlag - added a filter to filter out any trace flags which WHERE expected to prevent false positive alerts
Modified the docs to detail to install Pester 4.10.0 as a manual install as it is no longer installed via install-module dbachecks due to it being removed as Pester5 breaks a lot of things
Copy link
Collaborator

@SQLDBAWithABeard SQLDBAWithABeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@SQLDBAWithABeard SQLDBAWithABeard merged commit a8ad3ba into dataplat:development Nov 23, 2020
@Ant-Green Ant-Green deleted the DocFix branch May 4, 2021 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants