New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore-HallengrenBackups.ps1 - Test-SQLSA Function - Sysadmin check fails if User is a member of an AD Group with SysAdmin permissions #2

Closed
dougjjj opened this Issue Jun 8, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@dougjjj

dougjjj commented Jun 8, 2015

If the user running the script is a SysAdmin via an AD Group, the function will report they do not have permissions to run the restore process.

I'm looking into options to check User is a member any AD Groups with SysAdmin rights

@potatoqualitee

This comment has been minimized.

Member

potatoqualitee commented Jun 9, 2015

Hey Doug,
That darn function keeps popping up. It's old code that I thought I fixed (it's fixed in start-sqlservermigration and others). I'll update the code tomorrow. Thanks for the note!

Sent from my iPhone

On Jun 9, 2015, at 1:17 AM, Doug notifications@github.com wrote:

If the user running the script is a SysAdmin via an AD Group, the function will report they do not have permissions to run the restore process.

I'm looking into options to check User is a member any AD Groups with SysAdmin rights


Reply to this email directly or view it on GitHub.

@dougjjj

This comment has been minimized.

dougjjj commented Jun 9, 2015

Hey Chrissy,

Sounds great. Awesome work on the scripts, they are a lifesaver, I just
inherited a server with 1650 databases that I'm migrating to SQL 2014 and I
can't imagine doing it without them :)

Cheers

Doug
On 9 Jun 2015 10:02 am, "Chrissy LeMaire" notifications@github.com wrote:

Hey Doug,
That darn function keeps popping up. It's old code that I thought I fixed
(it's fixed in start-sqlservermigration and others). I'll update the code
tomorrow. Thanks for the note!

Sent from my iPhone

On Jun 9, 2015, at 1:17 AM, Doug notifications@github.com wrote:

If the user running the script is a SysAdmin via an AD Group, the
function will report they do not have permissions to run the restore
process.

I'm looking into options to check User is a member any AD Groups with
SysAdmin rights


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#2 (comment)
.

@potatoqualitee

This comment has been minimized.

Member

potatoqualitee commented Jun 9, 2015

Wow 1650! That would have been a crazy paid if done manually. I'm so happy you found the script useful.

I've updated the code for both issues. Thanks for the pull request. It was my first :D

potatoqualitee pushed a commit that referenced this issue Jul 19, 2016

dansqldba pushed a commit that referenced this issue Aug 10, 2016

Merge pull request #2 from ctrlbold/development
Development - updates 08-09-2016

potatoqualitee pushed a commit that referenced this issue Dec 28, 2016

potatoqualitee pushed a commit that referenced this issue Feb 13, 2017

Merge pull request #2 from drewfurgiuele/it.1
removing my changes from main module, per instructions

niphlod added a commit to niphlod/dbatools that referenced this issue May 31, 2017

potatoqualitee pushed a commit that referenced this issue Jun 30, 2017

potatoqualitee pushed a commit that referenced this issue Aug 4, 2017

Merge pull request #2 from sqlcollaborative/development
Updating code before PR to head fork

wsmelton added a commit to wsmelton/dbatools that referenced this issue Sep 27, 2017

niphlod added a commit to zippy1981/dbatools that referenced this issue Oct 17, 2017

niphlod added a commit to zippy1981/dbatools that referenced this issue Oct 19, 2017

@niphlod niphlod referenced this issue Oct 23, 2017

Merged

Pester, coverage in Appveyor #2499

3 of 9 tasks complete

PowerDBAKlaas pushed a commit that referenced this issue Nov 18, 2017

Merge pull request #2 from josh-simar/josh-simar-patch-1
Changed to not use dbasize as issues

potatoqualitee pushed a commit that referenced this issue Dec 11, 2017

potatoqualitee pushed a commit that referenced this issue Jul 12, 2018

potatoqualitee pushed a commit that referenced this issue Oct 31, 2018

Merge pull request #2 from sqlcollaborative/master
sync sqlcollaborative/Master to wsuhoey/dbatools fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment