New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-DbaDiskSpace - Script Analyzer Test failure #379

Closed
SQLDBAWithABeard opened this Issue Dec 5, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@SQLDBAWithABeard
Contributor

SQLDBAWithABeard commented Dec 5, 2016

We're adding Pester tests and AppVeyor to dbatools, see https://github.com/sqlcollaborative/dbatools/wiki/AppVeyor-and-Pester for more detail.

The following rules were highlighted for this function:

RuleName Severity Line Message
PSAvoidUsingPlainTextForPassword Warning 128 Parameter '$SqlCredential' should use SecureString, otherwise this will expose sensitive information. See ConvertTo-SecureString for more information.
PSAvoidUsingWMICmdlet Warning 182 File 'Get-DbaDiskSpace.ps1' uses WMI cmdlet. For PowerShell 3.0 and above, use CIM cmdlet which perform the same tasks as the WMI cmdlets. The CIM cmdlets comply with WS-Management (WSMan) standards and with the Common Information Model (CIM) standard, which enables the cmdlets to use the same techniques to manage Windows computers and those running other operating systems.
PSUseDeclaredVarsMoreThanAssignments Warning 187 The variable 'query' is assigned but never used.
PSAvoidUsingWMICmdlet Warning 189 File 'Get-DbaDiskSpace.ps1' uses WMI cmdlet. For PowerShell 3.0 and above, use CIM cmdlet which perform the same tasks as the WMI cmdlets. The CIM cmdlets comply with WS-Management (WSMan) standards and with the Common Information Model (CIM) standard, which enables the cmdlets to use the same techniques to manage Windows computers and those running other operating systems.
PSAvoidUsingWMICmdlet Warning 210 File 'Get-DbaDiskSpace.ps1' uses WMI cmdlet. For PowerShell 3.0 and above, use CIM cmdlet which perform the same tasks as the WMI cmdlets. The CIM cmdlets comply with WS-Management (WSMan) standards and with the Common Information Model (CIM) standard, which enables the cmdlets to use the same techniques to manage Windows computers and those running other operating systems.
PSUseOutputTypeCorrectly Information 350 The cmdlet 'Get-DbaDiskSpace' returns an object of type 'System.Collections.ArrayList' but this type is not declared in the OutputType attribute.

@dansqldba dansqldba changed the title from Get-DbaDiskSpace Script Analyzer Test failure to Get-DbaDiskSpace - Script Analyzer Test failure Dec 5, 2016

@niphlod niphlod removed the general tools label Jan 12, 2017

@niphlod

This comment has been minimized.

Show comment
Hide comment
@niphlod

niphlod Feb 1, 2017

Contributor

see #627 , aka "the issue that tracked them all"

Contributor

niphlod commented Feb 1, 2017

see #627 , aka "the issue that tracked them all"

@niphlod niphlod closed this Feb 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment