Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bypass resolve-dbanetworkname #5101

Closed
potatoqualitee opened this issue Feb 19, 2019 · 3 comments
Closed

bypass resolve-dbanetworkname #5101

potatoqualitee opened this issue Feb 19, 2019 · 3 comments
Assignees
Labels
Projects

Comments

@potatoqualitee
Copy link
Member

image

@wsmelton
Copy link
Member

@nvarscar enter-pssession works fine if i enter ip address and fully qualified to server name. If i enter just servername thw error i get is the winrm error. When i enter the fully name to get-dbaservice commamd i get that no services found in relevant namespaces on

Based on this comment the user needs to be using the FQDN, or our commands need to be using that.

We have 75 functions that reference the resolve command, and all that I see explicitly using the FullComputerName property. So if that configuration goes in place we have to update all 75 commands to pick up whether or not the resolve should be called at all. Another option would be to have it determine whether or not we use hostname, IP or the FQDN and let the resolve command still be called.

If a user wants the FQDN, which is what it seems Kbarb needs, then they can Set-DbatoolsConfig -Name resolve.property -Value FQDN. We adjust Resolve-DbaNetworkName to have a special property for our internal calls and based on the value of that configuration is what true property value would be populated in it. At least that is off the top how I think it could work and be more configurable, the default value was be set to FullComputerName since that is what it does now.

@niphlod
Copy link
Contributor

niphlod commented Mar 8, 2019

yup, the main deal is always the same: mssql doesn't provide the FQDNSDomainName in any place.
So, either you pass in the FQDNSDomainName, which maps finely to both SQL and the underlying server, or when your FQADDomainName doesn't match your FQDNSDomainName, and/or client domain suffixes aren't sufficient (pun intended), we're truly impossibilitated to do anything 'cause netbios ain't gonna work.
Don't get why it's a problem with dbmail though ???
Resolve-* (to get FullComputerName) should come into play just when the function needs to play with both mssql and the underlying server.

@potatoqualitee
Copy link
Member Author

good call, ill return an object with all fields populated with the input

@potatoqualitee potatoqualitee added this to To do in 1.0 via automation Mar 17, 2019
@potatoqualitee potatoqualitee self-assigned this Mar 17, 2019
@potatoqualitee potatoqualitee moved this from To do to In progress in 1.0 Mar 18, 2019
potatoqualitee added a commit that referenced this issue Mar 18, 2019
also fixes an unreported bug where multiple computers are not processed
1.0 automation moved this from In progress to Done Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
1.0
  
Done
Development

No branches or pull requests

3 participants