Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-DbaErrorLogin listed on commands page but apparently does not exist #5844

Closed
SQLGB opened this issue Jul 1, 2019 · 9 comments · Fixed by #6186
Assignees

Comments

@SQLGB
Copy link
Contributor

@SQLGB SQLGB commented Jul 1, 2019

Environmental information

PSVersion 5.1.14409.1018
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.14409.1018
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1

dbatools Module version:

Name : dbatools
Path : C:\Program Files\WindowsPowerShell\Modules\dbatools\1.0.11\dbatools.psd1
Version : 1.0.11

1033 en-US English (United States)

SQL Server:

Microsoft SQL Server 2016 (SP2-CU2-GDR) (KB4458621) - 13.0.5201.2 (X64) Aug 18 2018 07:38:15 Copyright (c) Microsoft Corporation Enterprise Edition (64-bit) on Windows Server 2012 R2 Standard 6.3 (Build 9600: ) (Hypervisor)

us_english

Report

Host used

  • powershell.exe
  • ISE
  • VS Code
  • Other (please specify)

If anything other than powershell.exe was used, please confirm that you can duplicate the issue with powershell.exe

  • Still buggy in powershell.exe

Errors Received

Steps to Reproduce

Browse https://dbatools.io/commands/ find Get-DbaErrorLogin and click on it, or run "get-command Get-DbaErrorLogin" in PowerShell.

Expected Behavior

Help page or summary for valid command.

Actual Behavior

404 Function not found (web) and "get-command : The term 'Get-DbaErrorLogin' is not recognized as the name of a cmdlet..." in PowerShell. Suspect this is a result of a find/replace operation gone wrong (command name very similar to "Get-DbaErrorLog".

@potatoqualitee

This comment has been minimized.

Copy link
Member

@potatoqualitee potatoqualitee commented Jul 1, 2019

indeed that is true, thank you. i have updated the page 💯

@SQLGB

This comment has been minimized.

Copy link
Contributor Author

@SQLGB SQLGB commented Jul 1, 2019

@potatoqualitee FYI, same issue for these 8 commands:

Test-DbaDbDataGeneratorConfiguration
Get-DbaInstanceRole
New-DbaInstanceRole
Remove-DbaInstanceRole
Select-DbaObject
Get-DbaInstanceRoleMember
Find-DbaUnusedIndex
Set-DbatoolsConfig

@SQLGB

This comment has been minimized.

Copy link
Contributor Author

@SQLGB SQLGB commented Jul 1, 2019

Minor correction - these two are apparently found via get-command, but the online help pages don't exist...

Select-DbaObject
Set-DbatoolsConfig

@potatoqualitee

This comment has been minimized.

Copy link
Member

@potatoqualitee potatoqualitee commented Jul 1, 2019

Thanks so very much, @SQLGB I am unsure how I'm going to get the cmdlet help into there. @niphlod can you offer any suggestions? It exists in Get-Help, can we smash it into the json? @ClaudioESSilva would you be able to take a look at the webpage?

@potatoqualitee potatoqualitee reopened this Jul 1, 2019
@potatoqualitee

This comment has been minimized.

Copy link
Member

@potatoqualitee potatoqualitee commented Jul 9, 2019

ping @niphlod

@niphlod

This comment has been minimized.

Copy link
Contributor

@niphlod niphlod commented Jul 10, 2019

@potatoqualitee

This comment has been minimized.

Copy link
Member

@potatoqualitee potatoqualitee commented Jul 10, 2019

thanks niph!

@stale

This comment has been minimized.

Copy link

@stale stale bot commented Sep 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. If you would like this issue to remain open:

  • Verify that you can still reproduce the issue in the latest version of dbatools
  • Comment that the issue is still reproducible and include:
    • What version of dbatools you reproduced the issue on
    • What OS and version you reproduced the issue on
    • What steps you followed to reproduce the issue
@stale stale bot added the stale label Sep 8, 2019
@niphlod

This comment has been minimized.

Copy link
Contributor

@niphlod niphlod commented Sep 8, 2019

@stale stale bot removed the stale label Sep 8, 2019
@stale stale bot added the stale label Nov 7, 2019
@wsmelton wsmelton added the Confirmed label Nov 7, 2019
@stale stale bot removed the stale label Nov 7, 2019
@sqlcollaborative sqlcollaborative deleted a comment from stale bot Nov 7, 2019
wsmelton added a commit to wsmelton/dbatools that referenced this issue Nov 7, 2019
@wsmelton wsmelton referenced this issue Nov 7, 2019
1 of 10 tasks complete
potatoqualitee added a commit that referenced this issue Nov 7, 2019
* fixes #5844 add cmdlet help

* try catch for Get-Help, making command list unique

* Rebuilt index file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.