Appveyor build changes

[wsmelton]

Verified issue does not already exist?

Yes

What error did you receive?

Steps to Reproduce

N/A - this is issue with Appveyor runs

Are you running the latest release?

Yes

Other details or mentions

588e3cb

Changes in this PR bumped the .NET/dotnet SDK to 5.0 which is not supported for our library class file. Our project is not written to compile under 5.0 release right now. (And actually never can because it breaks functionality with PowerShell library for cross-platform support.)

What PowerShell host was used when producing this error

PowerShell Core (pwsh.exe)

PowerShell Host Version

N/A

SQL Server Edition and Build number

N/A

.NET Framework Version

Whatever Appveyor runs 🤷🏻

[wsmelton]

This run from a current PR also shows the failure but a different error message:

https://ci.appveyor.com/project/sqlcollaborative/dbatools/builds/41175424/job/4yclemy7kr3vhtty

[andreasjordan]

What can we do here?

[wsmelton]

How the library is built during Appveyor setup would need to be adjusted.

I'd personally like to move the library project to it's own project on GitHub so we can build and test it separately (using GitHub Actions). Then setup an action to publish it as a formal Nuget. Not an overnight change though 🤷.

[wsmelton]

If I recall from last looking at it the version of dotnet SDK we point at is wrong. Our library does not support dotnet 5.0.

[github-actions]

🚧🚨 This issue is being marked as stale due to 90 days of inactivity. If you would like this issue to remain open:

• Verify the issue/bug is reproduced in the latest version of the module
• Verify the environmental info provided is still accurate
• Add any additional steps you followed to reproduce if necessary
  🚨🚧
  ⌛️ This issue will be closed in 30 days ⌛️

[andreasjordan]

@potatoqualitee : Is this something you have to keep in mind for the new library module or 2.0?

[potatoqualitee]

yep! ty

[andreasjordan]

Looks like this is solved now. Can you confirm, @wsmelton ?