New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function Get-ErrorMessage to get inner exception of failed deploy… #4440

Merged
merged 3 commits into from Nov 7, 2018

Conversation

Projects
None yet
2 participants
@RichieBzzzt
Copy link
Contributor

RichieBzzzt commented Nov 7, 2018

Type of Change

  • Bug fix (non-breaking change, fixes #)

Purpose

Get inner exceptions when dacpac fails to deploy
adding Get-ErrorMessage that @potatoqualitee recommended to use (see #4396 )

Commands to test

Publish-DbaDacpackage

Learning

Catching exceptions is hard!
I really need to add negative tests for this function.

@RichieBzzzt

This comment has been minimized.

Copy link
Contributor

RichieBzzzt commented Nov 7, 2018

If change is merged, then #4396 issue can most likely be closed, pending feedback from OP.

@potatoqualitee

This comment has been minimized.

Copy link
Member

potatoqualitee commented Nov 7, 2018

thanks so much @RichieBzzzt ! I typed that out from memory. Did it work for you? 🙇

@RichieBzzzt

This comment has been minimized.

Copy link
Contributor

RichieBzzzt commented Nov 7, 2018

Certainly did thanks! That's an amazing function; does the trick.

@potatoqualitee

This comment has been minimized.

Copy link
Member

potatoqualitee commented Nov 7, 2018

fantastic :D thank you!

@potatoqualitee potatoqualitee merged commit 44e0ed3 into sqlcollaborative:development Nov 7, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment