Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mandatory = $false #4691

Merged
merged 1 commit into from Nov 27, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions functions/Backup-DbaDbCertificate.ps1
Expand Up @@ -122,9 +122,7 @@ function Backup-DbaDbCertificate {
[object[]]$Database,
[parameter(ParameterSetName = "instance")]
[object[]]$ExcludeDatabase,
[parameter(Mandatory = $false)]
[Security.SecureString]$EncryptionPassword,
[parameter(Mandatory = $false)]
[Security.SecureString]$DecryptionPassword,
[System.IO.FileInfo]$Path,
[string]$Suffix = "$(Get-Date -format 'yyyyMMddHHmmssms')",
Expand Down
1 change: 0 additions & 1 deletion functions/Copy-DbaDatabase.ps1
Expand Up @@ -166,7 +166,6 @@ function Copy-DbaDatabase {
[CmdletBinding(DefaultParameterSetName = "DbBackup", SupportsShouldProcess)]
[Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSUseOutputTypeCorrectly", "", Justification = "PSSA Rule Ignored by BOH")]
param (
[parameter(Mandatory = $false)]
[DbaInstanceParameter]$Source,
[PSCredential]$SourceSqlCredential,
[parameter(Mandatory)]
Expand Down
3 changes: 1 addition & 2 deletions functions/Find-DbaBackup.ps1
Expand Up @@ -71,7 +71,6 @@ function Find-DbaBackup {
[string]$BackupFileExtension ,
[parameter(Mandatory, HelpMessage = "Backup retention period. (ex. 24h, 7d, 4w, 6m)")]
[string]$RetentionPeriod ,
[parameter(Mandatory = $false)]
[switch]$CheckArchiveBit = $false ,
[Alias('Silent')]
[switch]$EnableException
Expand All @@ -97,7 +96,7 @@ function Find-DbaBackup {
'7d' = 7 days
'4w' = 4 weeks
'1m' = 1 month
#>
#>

[int]$Length = ($UserFriendlyRetention).Length
$Value = ($UserFriendlyRetention).Substring(0, $Length - 1)
Expand Down
2 changes: 0 additions & 2 deletions functions/Find-DbaOrphanedFile.ps1
Expand Up @@ -85,9 +85,7 @@ function Find-DbaOrphanedFile {
[parameter(Mandatory, ValueFromPipeline)]
[Alias("ServerInstance", "SqlServer")]
[DbaInstanceParameter[]]$SqlInstance,
[parameter(Mandatory = $false)]
[pscredential]$SqlCredential,
[parameter(Mandatory = $false)]
[string[]]$Path,
[string[]]$FileType,
[switch]$LocalOnly,
Expand Down
2 changes: 1 addition & 1 deletion functions/Get-DbaAgentJobOutputFile.ps1
Expand Up @@ -90,7 +90,7 @@ function Get-DbaAgentJobOutputFile {
[ValidateNotNullOrEmpty()]
[Alias("ServerInstance", "SqlServer")]
[DbaInstanceParameter[]]$SqlInstance,
[Parameter(Mandatory = $false, HelpMessage = 'SQL Credential',
[Parameter(HelpMessage = 'SQL Credential',
ValueFromPipelineByPropertyName = $true,
ValueFromRemainingArguments = $false,
Position = 1)]
Expand Down
2 changes: 1 addition & 1 deletion functions/Get-DbaBuildReference.ps1
Expand Up @@ -63,7 +63,7 @@ function Get-DbaBuildReference {
[version[]]
$Build,

[parameter(Mandatory = $false, ValueFromPipeline)]
[parameter(ValueFromPipeline)]
[Alias("ServerInstance", "SqlServer")]
[DbaInstanceParameter[]]
$SqlInstance,
Expand Down
8 changes: 4 additions & 4 deletions functions/Get-DbaQueryExecutionTime.ps1
Expand Up @@ -74,13 +74,13 @@ function Get-DbaQueryExecutionTime {
[Alias("Databases")]
[object[]]$Database,
[object[]]$ExcludeDatabase,
[parameter(Position = 1, Mandatory = $false)]
[parameter(Position = 1)]
[int]$MaxResultsPerDb = 100,
[parameter(Position = 2, Mandatory = $false)]
[parameter(Position = 2)]
[int]$MinExecs = 100,
[parameter(Position = 3, Mandatory = $false)]
[parameter(Position = 3)]
[int]$MinExecMs = 500,
[parameter(Position = 4, Mandatory = $false)]
[parameter(Position = 4)]
[Alias("ExcludeSystemDatabases")]
[switch]$ExcludeSystem,
[Alias('Silent')]
Expand Down
4 changes: 1 addition & 3 deletions functions/Get-DbaSpn.ps1
Expand Up @@ -52,11 +52,9 @@ function Get-DbaSpn {
[cmdletbinding()]
[Diagnostics.CodeAnalysis.SuppressMessageAttribute("PSUseApprovedVerbs", "", Justification = "Internal functions are ignored")]
param (
[Parameter(Mandatory = $false, ValueFromPipeline)]
[Parameter(ValueFromPipeline)]
[string[]]$ComputerName,
[Parameter(Mandatory = $false)]
[string[]]$AccountName,
[Parameter(Mandatory = $false)]
[PSCredential]$Credential,
[Alias('Silent')]
[switch]$EnableException
Expand Down
5 changes: 0 additions & 5 deletions functions/Get-DbaSsisEnvironmentVariable.ps1
Expand Up @@ -110,15 +110,10 @@ function Get-DbaSsisEnvironmentVariable {
[parameter(Mandatory, ValueFromPipeline)]
[Alias('SqlServer', 'ServerInstance')]
[DbaInstanceParameter[]]$SqlInstance,
[Parameter(Mandatory = $false)]
[PSCredential]$SqlCredential,
[parameter(Mandatory = $false)]
[object[]]$Environment,
[parameter(Mandatory = $false)]
[object[]]$EnvironmentExclude,
[parameter(Mandatory = $false)]
[object[]]$Folder,
[parameter(Mandatory = $false)]
[object[]]$FolderExclude,
[Alias('Silent')]
[switch]$EnableException
Expand Down
4 changes: 2 additions & 2 deletions functions/Get-DbaUserPermission.ps1
Expand Up @@ -63,7 +63,7 @@ function Get-DbaUserPermission {
Check server and database permissions on server sql2008 for only the TestDB database,
including public and guest grants, and sys schema objects.

#>
#>
[CmdletBinding()]
param (
[parameter(Position = 0, Mandatory, ValueFromPipeline)]
Expand All @@ -73,7 +73,7 @@ function Get-DbaUserPermission {
[Alias("Databases")]
[object[]]$Database,
[object[]]$ExcludeDatabase,
[parameter(Position = 1, Mandatory = $false)]
[parameter(Position = 1)]
[switch]$ExcludeSystemDatabase,
[switch]$IncludePublicGuest,
[switch]$IncludeSystemObjects,
Expand Down
1 change: 0 additions & 1 deletion functions/Install-DbaWhoIsActive.ps1
Expand Up @@ -75,7 +75,6 @@ function Install-DbaWhoIsActive {
[Alias("ServerInstance", "SqlServer")]
[DbaInstanceParameter[]]$SqlInstance,
[PsCredential]$SqlCredential,
[parameter(Mandatory = $false)]
[ValidateScript( { Test-Path -Path $_ -PathType Leaf })]
[string]$LocalFile,
[object]$Database,
Expand Down
75 changes: 0 additions & 75 deletions functions/Invoke-DbaDbLogShipping.ps1
Expand Up @@ -398,19 +398,15 @@ function Invoke-DbaDbLogShipping {
[Alias("DestinationServerInstance", "DestinationSqlServer", "Destination")]
[object[]]$DestinationSqlInstance,

[Parameter(Mandatory = $false)]
[System.Management.Automation.PSCredential]
$SourceSqlCredential,

[Parameter(Mandatory = $false)]
[System.Management.Automation.PSCredential]
$SourceCredential,

[Parameter(Mandatory = $false)]
[System.Management.Automation.PSCredential]
$DestinationSqlCredential,

[Parameter(Mandatory = $false)]
[System.Management.Automation.PSCredential]
$DestinationCredential,

Expand All @@ -420,230 +416,159 @@ function Invoke-DbaDbLogShipping {
[parameter(Mandatory)]
[string]$BackupNetworkPath,

[parameter(Mandatory = $false)]
[string]$BackupLocalPath,

[parameter(Mandatory = $false)]
[string]$BackupJob,

[parameter(Mandatory = $false)]
[int]$BackupRetention,

[parameter(Mandatory = $false)]
[string]$BackupSchedule,

[parameter(Mandatory = $false)]
[switch]$BackupScheduleDisabled,

[parameter(Mandatory = $false)]
[ValidateSet("Daily", "Weekly", "AgentStart", "IdleComputer")]
[object]$BackupScheduleFrequencyType,

[parameter(Mandatory = $false)]
[object[]]$BackupScheduleFrequencyInterval,

[parameter(Mandatory = $false)]
[ValidateSet('Time', 'Seconds', 'Minutes', 'Hours')]
[object]$BackupScheduleFrequencySubdayType,

[parameter(Mandatory = $false)]
[int]$BackupScheduleFrequencySubdayInterval,

[Parameter(Mandatory = $false)]
[ValidateSet('Unused', 'First', 'Second', 'Third', 'Fourth', 'Last')]
[object]$BackupScheduleFrequencyRelativeInterval,

[Parameter(Mandatory = $false)]
[int]$BackupScheduleFrequencyRecurrenceFactor,

[parameter(Mandatory = $false)]
[string]$BackupScheduleStartDate,

[parameter(Mandatory = $false)]
[string]$BackupScheduleEndDate,

[parameter(Mandatory = $false)]
[string]$BackupScheduleStartTime,

[parameter(Mandatory = $false)]
[string]$BackupScheduleEndTime,

[parameter(Mandatory = $false)]
[int]$BackupThreshold,

[parameter(Mandatory = $false)]
[switch]$CompressBackup,

[parameter(Mandatory = $false)]
[string]$CopyDestinationFolder,

[parameter(Mandatory = $false)]
[string]$CopyJob,

[parameter(Mandatory = $false)]
[int]$CopyRetention,

[parameter(Mandatory = $false)]
[string]$CopySchedule,

[parameter(Mandatory = $false)]
[switch]$CopyScheduleDisabled,

[parameter(Mandatory = $false)]
[ValidateSet("Daily", "Weekly", "AgentStart", "IdleComputer")]
[object]$CopyScheduleFrequencyType,

[parameter(Mandatory = $false)]
[object[]]$CopyScheduleFrequencyInterval,

[parameter(Mandatory = $false)]
[ValidateSet('Time', 'Seconds', 'Minutes', 'Hours')]
[object]$CopyScheduleFrequencySubdayType,

[parameter(Mandatory = $false)]
[int]$CopyScheduleFrequencySubdayInterval,

[Parameter(Mandatory = $false)]
[ValidateSet('Unused', 'First', 'Second', 'Third', 'Fourth', 'Last')]
[object]$CopyScheduleFrequencyRelativeInterval,

[Parameter(Mandatory = $false)]
[int]$CopyScheduleFrequencyRecurrenceFactor,

[parameter(Mandatory = $false)]
[string]$CopyScheduleStartDate,

[parameter(Mandatory = $false)]
[string]$CopyScheduleEndDate,

[parameter(Mandatory = $false)]
[string]$CopyScheduleStartTime,

[parameter(Mandatory = $false)]
[string]$CopyScheduleEndTime,

[parameter(Mandatory = $false)]
[switch]$DisconnectUsers,

[parameter(Mandatory = $false)]
[string]$FullBackupPath,

[parameter(Mandatory = $false)]
[switch]$GenerateFullBackup,

[parameter(Mandatory = $false)]
[int]$HistoryRetention,

[parameter(Mandatory = $false)]
[switch]$NoRecovery,

[parameter(Mandatory = $false)]
[switch]$NoInitialization,

[Parameter(Mandatory = $false)]
[string]$PrimaryMonitorServer,

[Parameter(Mandatory = $false)]
[System.Management.Automation.PSCredential]
$PrimaryMonitorCredential,

[Parameter(Mandatory = $false)]
[ValidateSet(0, "sqlserver", 1, "windows")]
[object]$PrimaryMonitorServerSecurityMode,

[Parameter(Mandatory = $false)]
[switch]$PrimaryThresholdAlertEnabled,

[parameter(Mandatory = $false)]
[string]$RestoreDataFolder,

[parameter(Mandatory = $false)]
[string]$RestoreLogFolder,

[parameter(Mandatory = $false)]
[int]$RestoreDelay,

[parameter(Mandatory = $false)]
[int]$RestoreAlertThreshold,

[parameter(Mandatory = $false)]
[string]$RestoreJob,

[parameter(Mandatory = $false)]
[int]$RestoreRetention,

[parameter(Mandatory = $false)]
[string]$RestoreSchedule,

[parameter(Mandatory = $false)]
[switch]$RestoreScheduleDisabled,

[parameter(Mandatory = $false)]
[ValidateSet("Daily", "Weekly", "AgentStart", "IdleComputer")]
[object]$RestoreScheduleFrequencyType,

[parameter(Mandatory = $false)]
[object[]]$RestoreScheduleFrequencyInterval,

[parameter(Mandatory = $false)]
[ValidateSet('Time', 'Seconds', 'Minutes', 'Hours')]
[object]$RestoreScheduleFrequencySubdayType,

[parameter(Mandatory = $false)]
[int]$RestoreScheduleFrequencySubdayInterval,

[Parameter(Mandatory = $false)]
[ValidateSet('Unused', 'First', 'Second', 'Third', 'Fourth', 'Last')]
[object]$RestoreScheduleFrequencyRelativeInterval,

[Parameter(Mandatory = $false)]
[int]$RestoreScheduleFrequencyRecurrenceFactor,

[parameter(Mandatory = $false)]
[string]$RestoreScheduleStartDate,

[parameter(Mandatory = $false)]
[string]$RestoreScheduleEndDate,

[parameter(Mandatory = $false)]
[string]$RestoreScheduleStartTime,

[parameter(Mandatory = $false)]
[string]$RestoreScheduleEndTime,

[parameter(Mandatory = $false)]
[int]$RestoreThreshold,

[parameter(Mandatory = $false)]
[string]$SecondaryDatabasePrefix,

[parameter(Mandatory = $false)]
[string]$SecondaryDatabaseSuffix,

[Parameter(Mandatory = $false)]
[string]$SecondaryMonitorServer,

[Parameter(Mandatory = $false)]
[System.Management.Automation.PSCredential]
$SecondaryMonitorCredential,

[Parameter(Mandatory = $false)]
[ValidateSet(0, "sqlserver", 1, "windows")]
[object]$SecondaryMonitorServerSecurityMode,

[Parameter(Mandatory = $false)]
[switch]$SecondaryThresholdAlertEnabled,

[parameter(Mandatory = $false)]
[switch]$Standby,

[parameter(Mandatory = $false)]
[string]$StandbyDirectory,

[parameter(Mandatory = $false)]
[switch]$UseExistingFullBackup,

[parameter(Mandatory = $false)]
[string]$UseBackupFolder,

[switch]$Force,
Expand Down