New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationIntent fixes #4947

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
2 participants
@nvarscar
Copy link
Contributor

nvarscar commented Jan 11, 2019

Type of Change

  • Bug fix (non-breaking change, fixes #4946)
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Fixing ApplicationIntent that causes authentication failures

Approach

ApplicationIntent is now set as a parameter, not inside the connection string.
With that said, setting one of MultiSubnetFailover and FailoverPartner parameters will cause the same exact issues when used together with SqlCredential.

Commands to test

Invoke-DbaQuery -ReadOnly:$true/$false
Connect-DbaIntsance -ApplicationIntent Readonly

Screenshots

Learning

@potatoqualitee

This comment has been minimized.

Copy link
Member

potatoqualitee commented Jan 11, 2019

oh thank god, thank you

@potatoqualitee potatoqualitee merged commit fbad96f into sqlcollaborative:development Jan 11, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment