New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Update-DbaInstance: parallelism, exceptions #5053

Merged
merged 2 commits into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@nvarscar
Copy link
Contributor

nvarscar commented Feb 5, 2019

Type of Change

  • Bug fix (non-breaking change, fixes #4988 )
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Fixing issue raised by @wsmelton as well as some annoying parallelism fix that can't be tested in Appveyor (adding -ImportFunctions to the Invoke-Parallel fixes inability to use internal commands inside the script block).

Approach

no EnableException in the internals
try-catches everywhere

Commands to test

Update-DbaInstance -ComputerName srv1, srv2

Screenshots

Learning

@potatoqualitee

This comment has been minimized.

Copy link
Member

potatoqualitee commented Feb 5, 2019

@wsmelton - can you test?

@potatoqualitee

This comment has been minimized.

Copy link
Member

potatoqualitee commented Feb 5, 2019

thanks so much @nvarscar 🙇

@potatoqualitee potatoqualitee merged commit 30cda65 into sqlcollaborative:development Feb 6, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvarscar nvarscar deleted the nvarscar:runspace-internals branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment