Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect-DbaInstance enhancements #5205

Merged
merged 17 commits into from Mar 15, 2019

Conversation

Projects
None yet
1 participant
@potatoqualitee
Copy link
Member

potatoqualitee commented Mar 15, 2019

  • make it work better with azure
  • add netport for future potential fix in dbatools library

potatoqualitee added some commits Mar 12, 2019

bypass enumeration to allow azure support
// the extra checks break azure by enumerating, causing a new
// connection and sometimes altering the connection string
// so let's just accept computername

AzureSqlDb only runs on 1433 so it shouldn't need to parse the port
bypass enumeration to allow azure support
// the extra checks break azure by enumerating, causing a new
// connection and sometimes altering the connection string
// so let's just accept computername

AzureSqlDb only runs on 1433 so it shouldn't need to parse the port
@potatoqualitee

This comment has been minimized.

Copy link
Member Author

potatoqualitee commented Mar 15, 2019

one failure due to appveyor 🙄

@potatoqualitee potatoqualitee changed the title Invokedbaquery updates Connect-DbaInstance enhancements Mar 15, 2019

@potatoqualitee potatoqualitee merged commit 4fcfeac into development Mar 15, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details

@potatoqualitee potatoqualitee deleted the invokedbaquery branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.