Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fallbacks for Expand-Archive (do Get-DbaDatabase) #5731

Merged

Conversation

Projects
None yet
2 participants
@niphlod
Copy link
Contributor

commented Jun 11, 2019

Type of Change

  • Bug fix (non-breaking change, fixes resurfacing things like #4800)
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

We definitely import optional\ (for all import modes, allcommands.ps1 or not). So we do have everywhere Expand-Archive and Compress-Archive at our disposal.

Approach

Remove any instance of shell.application and create a regression test to make sure it doesn't ever happen again

@potatoqualitee potatoqualitee merged commit 8fa19e6 into sqlcollaborative:prerelease Jun 12, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.