Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting connection messages and removing unused code #6087

Merged
merged 16 commits into from Oct 9, 2019

Conversation

@wsmelton
Copy link
Member

commented Oct 3, 2019

  • Connection error messages that didn't conform to standard.
  • Removed return from Read-DbaTraceFile since it was to process multiple servers.
@wsmelton

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2019

So I didn't change any code on the read trace file command except correct the connection error message. However now the mocks that are in this test are broke for some reason in Appveyor.

It runs fine on my local test. Someone else may want to try it on their system to see if it works or breaks for them.

wsmelton added 3 commits Oct 8, 2019
@wsmelton wsmelton merged commit d736701 into sqlcollaborative:development Oct 9, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@wsmelton wsmelton deleted the wsmelton:fix-hotones branch Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.