Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get sql server key add 2016 support #610

Merged
merged 2 commits into from Jan 30, 2017
Merged

Conversation

@ConstantineK
Copy link
Contributor

ConstantineK commented Jan 30, 2017

Fixes #215

Changes proposed in this pull request:

  • Add one liner to support 2016 paths and messages.
  • Added simple debug statement to verify my assumptions

How to test this code:

  • This is a minimal bug fix, but you should now be able to Get-SqlServerKey Sql2016 | select "Product Key" on SQL 2016 instances.
Still need to test on 2016 box, fixes #215
@potatoqualitee

This comment has been minimized.

Copy link
Member

potatoqualitee commented Jan 30, 2017

Hell yes this works well! Thanks bud!

@potatoqualitee potatoqualitee merged commit fa54436 into development Jan 30, 2017
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
contributing/gitmagic/commit Commit message passed all rules.
Details
contributing/gitmagic/pr Pull request passed all rules.
Details
@potatoqualitee potatoqualitee deleted the get-SqlServerKey-Add2016 branch Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.