Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address help index for cmdlets #6186

Merged

Conversation

@wsmelton
Copy link
Member

wsmelton commented Nov 7, 2019

Type of Change

  • Bug fix (non-breaking change, fixes #5844 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

A few things addressed:

  • Errors seen in command on rebuilding with some SMO types it cannot find (not sure why these are showing). I just wrapped the call to Get-Help in try/catch to deal with this:
    image

Now we get the pretty and proper warning messages:
image

  • Adding in pulling the help for the cmdlets for some reason caused the Select-DbaObject to show up twice in the index file. To prevent this I just adjusted the output to be unique.
@potatoqualitee

This comment has been minimized.

Copy link
Member

potatoqualitee commented Nov 7, 2019

Thanks shawn!

not sure why these are showing

they are showing bc my SMO / DLL skills are garbage and I used them as type in the param list. to make them go away, we can do [object[]]

@potatoqualitee potatoqualitee merged commit ee4b963 into sqlcollaborative:development Nov 7, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@potatoqualitee

This comment has been minimized.

Copy link
Member

potatoqualitee commented Nov 7, 2019

tests pass ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.