Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-DbaSpConfigure - Update to include SQL Server 2019 Settings #6427

Merged
merged 4 commits into from Mar 24, 2020

Conversation

@wsmelton
Copy link
Member

wsmelton commented Mar 19, 2020

Type of Change

  • Bug fix (non-breaking change, fixes #6425 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Learning

Adding version 15 to the switch statement in Get-SqlDefaultSpConfigure as this is where we store that data. (Down the road it might be worth moving this to a json file or something, having each setting listed together with an array of versions and the associated default value).

In Get-DbaSpConfigure we have an object that takes the display name and makes a "dummy" PascelName to more easily reference it in code when comparing, and recall this is for piping to Set command as well.

wsmelton added 3 commits Mar 19, 2020
fixes #6425
Reordered object list to make it easier to maintain. Added new features found in RTM of SQL Server 2019
@wsmelton

This comment has been minimized.

Copy link
Member Author

wsmelton commented Mar 19, 2020

This needs confirmation or review from someone that has an RTM default install of SQL Server 2019 to make sure I didn't miss anything.

@wsmelton wsmelton merged commit 81e3704 into development Mar 24, 2020
5 checks passed
5 checks passed
Module imports on all platforms (ubuntu-latest)
Details
Module imports on all platforms (windows-latest)
Details
Module imports on all platforms (macOS-latest)
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@wsmelton wsmelton deleted the GetSpConfigure-Add2019 branch Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.