New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres: Add ALTER TYPE
support
#3265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder should be moved to the Postgres dialect.
I've had a look around and very few dialects support custom types (so think we should move the CreateTypeSegment
to Postgres too btw, and only Postgres seems to support ALTER TYPE
.
Snowflake also removes the CreateTypeStatementSegment
so similarly we should remove AlterTypeStatementSegment
if we're not moving this to Postgres, but think we should move it.
WDYT?
Codecov Report
@@ Coverage Diff @@
## main #3265 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 167 167
Lines 12539 12542 +3
=========================================
+ Hits 12539 12542 +3
Continue to review full report at Codecov.
|
Yeah, I'll move both 👍 |
ALTER TYPE
support
Brief summary of the change made
Adds the most common things for
ALTER TYPE
. It's probably enough to close the issue. I can add the remaining things when I get a chance.Closes #3216
Are there any other side effects of this change that we should be aware of?
I put it under
dialect_ansi
to match whereCreateTypeStatementSegment
is. It's also fine if we want to move it todialect_postgres
.Pull Request checklist
Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withtox -e generate-fixture-yml
).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.