Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres: Add ALTER TYPE support #3265

Merged
merged 5 commits into from May 5, 2022
Merged

Conversation

greg-finley
Copy link
Contributor

@greg-finley greg-finley commented May 5, 2022

Brief summary of the change made

Adds the most common things for ALTER TYPE. It's probably enough to close the issue. I can add the remaining things when I get a chance.

Closes #3216

Are there any other side effects of this change that we should be aware of?

I put it under dialect_ansi to match where CreateTypeStatementSegment is. It's also fine if we want to move it to dialect_postgres.

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.
  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder should be moved to the Postgres dialect.

I've had a look around and very few dialects support custom types (so think we should move the CreateTypeSegment to Postgres too btw, and only Postgres seems to support ALTER TYPE.

Snowflake also removes the CreateTypeStatementSegment so similarly we should remove AlterTypeStatementSegment if we're not moving this to Postgres, but think we should move it.

WDYT?

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #3265 (5642620) into main (03d9799) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #3265   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          167       167           
  Lines        12539     12542    +3     
=========================================
+ Hits         12539     12542    +3     
Impacted Files Coverage Δ
src/sqlfluff/dialects/dialect_ansi.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_snowflake.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_tsql.py 100.00% <ø> (ø)
src/sqlfluff/dialects/dialect_postgres.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d9799...5642620. Read the comment docs.

@greg-finley
Copy link
Contributor Author

Yeah, I'll move both 👍

@tunetheweb tunetheweb changed the title Add ALTER TYPE, closes #3216 Postgres: Add ALTER TYPE support May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres: ALTER TYPE throws a "Found unparsable section" error.
2 participants