sqlite-wasm/jswasm/sqlite3-node.mjs does not exist

[singpolyma]

so import under nodejs fails, even if not used.

[sgbeal]

This project supports only browser deployments, not node. The canonical tree can build node builds but they are 100% untested beyond for compilability and we do not publish such builds.

[singpolyma]

Should https://github.com/sqlite/sqlite-wasm/blob/main/node.mjs be removed then since it references a file that does not exist?

[sgbeal]

That's up to @tomayac - he decides what goes into this tree. The upstream tree, however, very specifically does not, and has no plans to, support node.

[tomayac]

@sgbeal I will say that 3.51.0 was a bit of a surprise. Several files changed names or disappeared, see 0c48c20 for some changes that I needed to make. One of the missing files, which definitely was still there in 3.50.0, is jswasm/sqlite3-node.mjs. Could you check if those file name changes and the removal were on purpose?

[sgbeal]

The nodes builds are part of the build process, but they were never intended to be one of our deliverables. You are are course free to include them here but i'm adamant about not going down the rabbit hole of node support myself. "make b-node" from the ext/wasm dir will include them:

[🍟 jswasm/node/sqlite3-node.js]: ⏳ building ...
[🍟 jswasm/node/sqlite3-node.js]: 🔥🔥🔥Unsupported build: use at your own risk!
[🍟 jswasm/node/sqlite3-node.js]: 🐞 Fragile workaround for emscripten/issues/18237. See b.call.patch-export-default.
[🍟 ./jswasm/node/sqlite3-node.wasm] 💈 wasm-strip
[🍟 ./jswasm/node/sqlite3-node.wasm] 🧼 /home/stephan/src/emsdk/upstream/bin/wasm-opt
[🍟 jswasm/node/sqlite3-node.js]: 🐞 (disabled because it breaks emsdk 4.0.16+)
[🍟 jswasm/node/sqlite3-node.js]: 💾 jswasm/node/sqlite3-node.js ==> ./jswasm
[🍟 jswasm/node/sqlite3-node.js]: 💾 jswasm/node/sqlite3-node.wasm ==> ./jswasm
[🍟 jswasm/node/sqlite3-node.js]: ✅ done! 🔥🔥🔥Unsupported build: use at your own risk!

see 0c48c20 for some changes that I needed to make

Ah, the bundler-friendly one i'd forgotten about (it falls into the category for node/npm because only node-based tools use them). That file has historically been an unfortunate necessary evil. It was byte-for-byte identical to sqlite3.mjs but our build process had no good way to deal with multiple builds having identical JS/WASM results but different resulting filenames (like "bundler-friendly"). The build recently leveled up and now differentiates between intermediary builds and the final deliverables¹. It post-processes the intermediary builds to filter out the pieces which have identical JS/WASM content to the canonical builds (but different names, like "bundler-friendly"), and replaces the appropriate names in their Emscripten-generated module.

Footnotes

1. Which also allows it to run in parallel, which it couldn't effectively do before. "make -j4" of 8 separate builds now runs faster than the 3 or 4 builds we had before. That's also why the emoji were added - to help my eyes separate them during parallel builds. ↩

[tomayac]

The nodes builds are part of the build process, but they were never intended to be one of our deliverables.

I download the zip from https://sqlite.org/download.html, and the sqlite3-node.js file used to be part of it. Could you make it part of the .zip again? I never made any changes to the files I get from your server, just provide a thin wrapper around them, so npm is happy.

[sgbeal]

and the sqlite3-node.js file used to be part of it. Could you make it part of the .zip again?

It wasn't supposed to have been there (my fault!) and has never been supported or tested. Distributing it gives people the notion that it's supported, but we literally don't even test that build beyond "it compiles" and the first time it doesn't build it will get turned off rather than fix it. Thus i'm truly hesitant to re-add it but will reconsider it.

[tomayac]

I think people understand that Node.js support is best-effort at best, and no one has complained so far about the way it did work, but people have complained about the missing file, so if this helps you make a decision, I'd also vouch for you to add the file back.

[jlarmstrongiv]

Ouch! I also depend on that missing file, which blocks upgrading to the latest version of SQLite.