Permalink
Browse files

Crash when browsing a table, deleting it and back to the data browser

Following these steps a crash was observed:
1. Browse a Table T in "Browse Data" tab
2. Change to "Database Structure" tab and delete table T
3. Return to "Browse Data" tab

The application crashed because the combo still had the deleted table
value. It was too soon for the updateInsertDeleteRecordButton() call.
Moving it to the end of the method solves the issue.
  • Loading branch information...
mgrojo committed Jul 29, 2018
1 parent e1ef492 commit 2701223aac892d167ff4726b6c71e35d5cf77c43
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/MainWindow.cpp
@@ -525,8 +525,6 @@ void MainWindow::populateTable()
updateInsertDeleteRecordButton();
});
}
updateInsertDeleteRecordButton();

// Search stored table settings for this table
bool storedDataFound = browseTableSettings.contains(tablename);

@@ -637,6 +635,8 @@ void MainWindow::populateTable()
ui->actionShowRowidColumn->setVisible(false);
}

updateInsertDeleteRecordButton();

QApplication::restoreOverrideCursor();
}

0 comments on commit 2701223

Please sign in to comment.