Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active filters are not updated on table modification #1020

Closed
eevleevs opened this issue May 24, 2017 · 6 comments
Closed

Active filters are not updated on table modification #1020

eevleevs opened this issue May 24, 2017 · 6 comments
Labels

Comments

@eevleevs
Copy link

@eevleevs eevleevs commented May 24, 2017

Details for the issue

  • set a filter on one column on "browse data"
  • modify the table adding another column before the one with the filter
  • the filter is in the same position, but not anymore on the same field

Useful extra information

I'm opening this issue because:

  • DB4S is crashing
  • DB4S has a bug
  • DB4S needs a feature
  • DB4S has another problem

I'm using DB4S on:

  • Windows: ( version: ___ )
  • Linux: ( distro: ___ )
  • Mac OS: ( version: ___ )
  • Other: ___

I'm using DB4S version:

  • 3.9.1
  • 3.9.0
  • Other: ___

I have also:

@eevleevs eevleevs changed the title Active filters position is not updated on table modification Active filters are not updated on table modification May 24, 2017
@justinclift
Copy link
Member

@justinclift justinclift commented May 24, 2017

Interesting bug, thanks for reporting it. 😄

@prutz1311
Copy link
Contributor

@prutz1311 prutz1311 commented Jul 12, 2017

There is no way for DB4S to keep track of columns when modifying a table, that is, it cannot relate the columns before modification to the ones after modification, so it seems to be impossible to move values in filter lines into right positions. Should we instead just clear all filters on table modification?

@justinclift
Copy link
Member

@justinclift justinclift commented Jul 18, 2017

@prutz1311 Thinking about it, that's probably a reasonable approach. But it also sounds like the kind of thing which would need to be tried out to make sure it "feels ok" when used.

For something like this I'd probably implement it as fast as possible (no error checking) just to try out the workflow. eg to have something to try in the GUI. Then if the user experience seems ok, I'd then add the proper error checking to make the code quality reasonable.

But, it's completely up to you if you're considering doing it. 😄

prutz1311 added a commit to prutz1311/sqlitebrowser that referenced this issue Sep 10, 2017
Fixes sqlitebrowser#1020. Clear values in the filter boxes
on the `Data` tab every time the table structure
changes.
MKleusberg added a commit that referenced this issue Sep 10, 2017
Fixes #1020. Clear values in the filter boxes
on the `Data` tab every time the table structure
changes.
@MKleusberg
Copy link
Member

@MKleusberg MKleusberg commented Sep 12, 2017

Oops, accidentally closed this via that commit 😄

@eevleevs Thanks to @prutz1311 it's now at least clearing the filter row. That's still not as good as remembering the filter results and reapplying them to the new schema but it's probably all we can do for now. Are you ok to download the latest nightly build and see how it works out this way?

@MKleusberg MKleusberg reopened this Sep 12, 2017
@eevleevs
Copy link
Author

@eevleevs eevleevs commented Sep 14, 2017

Good for me, thanks.

@justinclift
Copy link
Member

@justinclift justinclift commented Sep 14, 2017

Awesome. Thanks @eevleevs. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants