New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Duplicate Record' doesn't duplicate selection #1090

Closed
chrisjlocke opened this Issue Aug 17, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@chrisjlocke
Copy link
Contributor

chrisjlocke commented Aug 17, 2017

Details for the issue

Guess its not a bug per-se, as the menu option is 'Duplicate Record' and not 'Duplicate Records', but when you select a number of records, right click, and select 'Duplicate Record', only the record you right clicked on (so not necessarily the first / last record in the selection) is duplicated.

It would be nice if the selected records were duplicated and not just the record you right clicked on.

Linked to this, is that the right click doesn't cancel (or set) the selection under the mouse, so you could highlight rows 8 to 11, then right click row 3 and select 'Duplicate Record'. Under 'normal' circumstances (in Windows, anyway), right clicking on row 3 (if not currently selected) would cancel the current selection and highlight row 3. The selection does not get cancelled if right clicking a row is already selected.

Useful extra information

I'm opening this issue because:

  • DB4S is crashing
  • DB4S has a bug
  • DB4S needs a feature
  • DB4S has another problem

I'm using DB4S on:

  • Windows: ( version: ___ )
  • Linux: ( distro: ___ )
  • Mac OS: ( version: ___ )
  • Other: ___

I'm using DB4S version:

  • 3.10.0-beta2
  • 3.10.0-beta1
  • 3.9.1
  • Other: ___

I have also:

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Aug 17, 2017

Yep, makes sense. 😄

@mgrojo mgrojo self-assigned this Jan 5, 2018

mgrojo added a commit that referenced this issue Jan 5, 2018

Allow deleting and duplicating a selection of rows
Before bbac655 it was possible to delete
a set of selected rows. This makes it possible again by only selecting the
row if it is not already inside the selected rows. See issue #1283.

Additionally and for coherence, the "Duplicate record" from the context
menu is also made to apply to the list of selected rows. See issue #1090
@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Jan 6, 2018

@chrisjlocke Should this be closed now? 😄

@chrisjlocke

This comment has been minimized.

Copy link
Contributor Author

chrisjlocke commented Jan 6, 2018

Forgot about this! Ooh. Yes, thanks to @mgrojo, another issue is squished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment