Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect encoding for tooltip #1107

Closed
4 of 14 tasks
Vort opened this issue Aug 28, 2017 · 13 comments
Closed
4 of 14 tasks

Incorrect encoding for tooltip #1107

Vort opened this issue Aug 28, 2017 · 13 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@Vort
Copy link

Vort commented Aug 28, 2017

Details for the issue

When I type COUNT( at SQL tab, tooltip with ??? characters instead of russian text pops out:

sqb

There should be COUNT(X) Функция count(X) возвращает количесвто строк, в которых X не равно NULL в группе. message.

BTW, there is a typo in this text: количесвто should be количество.

Useful extra information

I'm opening this issue because:

  • DB4S is crashing
  • DB4S has a bug
  • DB4S needs a feature
  • DB4S has another problem

I'm using DB4S on:

  • Windows: ( version: 7 SP1 x64 )
  • Linux: ( distro: ___ )
  • Mac OS: ( version: ___ )
  • Other: ___

I'm using DB4S version:

  • 3.10.0
  • 3.10.0-beta*
  • 3.9.1
  • Other: ___

I have also:

@justinclift justinclift added the bug Confirmed bugs or reports that are very likely to be bugs. label Aug 28, 2017
@justinclift
Copy link
Member

Thanks @Vort, that does look like a bug. 😄

We probably won't have time to look at it for a few days though. 😦

With the typo, I'll get that fixed later today.

@MKleusberg
Copy link
Member

The problem seems to be with Scintilla. Here they say, it can be fixed by using a different font but with the two fonts I've tried so far I didn't have any luck.

@justinclift
Copy link
Member

Oops, I forgot to fix the typo too.

justinclift added a commit that referenced this issue Sep 1, 2017
@justinclift
Copy link
Member

Typo now fixed: ddd08a4

MKleusberg pushed a commit that referenced this issue Sep 18, 2017
@to302
Copy link

to302 commented Oct 31, 2017

ko_KR has same problem. (version 3.10.99)

@mgrojo
Copy link
Member

mgrojo commented Nov 1, 2017

The same problem is reproduced in Spanish with accented characters. I'm looking into this, but the Scintilla code related to encoding is specially convoluted. I can make the tooltip to present correctly in Spanish, but then, the text encoding in the editor is broken...

@mgrojo mgrojo closed this as completed in 3a0e29c Nov 1, 2017
@mgrojo
Copy link
Member

mgrojo commented Nov 1, 2017

Wow, I didn't know that my comment in the commit would close the Issue. Nevertheless I've tested it for Spanish, Russian and Korean and is working for me.

@justinclift
Copy link
Member

@mgrojo Yeah, that automatically-close-the-issue based on keywords has caught everyone else out a few times too already. 😉

@Vort @to302 Would you have time to try the nightly build tomorrow? Thanks to @mgrojo this should be fixed now. 😄

@Vort
Copy link
Author

Vort commented Nov 2, 2017

Fixed. Thanks.

@justinclift
Copy link
Member

Thanks for checking @Vort. Good stuff @mgrojo. 😄

@MKleusberg
Copy link
Member

Glad this is finally fixed 😄 Just wanted to mention that we should probably send this to upstream QScintilla too but apparently they just fixed it yesterday: https://www.riverbankcomputing.com/static/Downloads/QScintilla/ChangeLog-2.10.2.dev1711012104. Maybe they are watching us 😆

@mgrojo
Copy link
Member

mgrojo commented Nov 2, 2017

Maybe they are watching us, but I sent them yesterday a patch 😅 I didn't want that my fix was lost for other users or for future updates of our QScintilla copy. Glad they have so soon applied it.

@MKleusberg
Copy link
Member

Cool, good thinking 😃

mgrojo added a commit that referenced this issue Oct 9, 2020
…cters

There is a further problem when the calltip is displayed after clicking
one of the arrows for overloaded functions.

This was first reported in #1107 (Russian) and #1206 (Korean). The subcase
has been reported in PR #2424.

Patch reported in the QScintilla list, so there is no need to keep a new
patch. It is assumed to come in new QScintilla versions.
mgrojo added a commit that referenced this issue Oct 9, 2020
…cters

There is a further problem when the calltip is displayed after clicking
one of the arrows for overloaded functions.

This was first reported in #1107 (Russian) and #1206 (Korean). The subcase
has been reported in PR #2424.

Patch reported in the QScintilla list, so there is no need to keep a new
patch. It is assumed to come in new QScintilla versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

5 participants