New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute SQL tab: UI tweak. Move "Export to CSV" button to top row #1122

Closed
justinclift opened this Issue Sep 8, 2017 · 13 comments

Comments

Projects
None yet
3 participants
@justinclift
Copy link
Member

justinclift commented Sep 8, 2017

Details for the issue

An UI optimisation has been suggested by a new-to-SQL user here:

    https://discuss.zetetic.net/t/save-query-results-as-csv/2343/4

In the issue discussion thread there, they were looking for the Execute SQL tab's "Export to CSV" button in the top row, where all of the other buttons are.

It might be decent idea to move it there, so that new users find it easier. It shouldn't be much/any problem for more experienced users to locate it's new location. 😄

I'm opening this issue because:

  • DB4S has another problem

I'm using DB4S version:

  • 3.10.0
@chrisjlocke

This comment has been minimized.

Copy link
Contributor

chrisjlocke commented Sep 8, 2017

Its not a 'global' button though, but a tab-related button - the button (if moved) would have to know what tab you're on about, and talk to the controls on that tab. I don't know Qt, but from my VB eyes, it looks like a lot of work....

@justinclift

This comment has been minimized.

Copy link
Member Author

justinclift commented Sep 8, 2017

Oops, I should have been clearer. 😄

db4s-1122_from

db4s-1122_to

@chrisjlocke

This comment has been minimized.

Copy link
Contributor

chrisjlocke commented Sep 9, 2017

Yup, got that. But it's still related to the tab its on. Actually (now my brain is plugged in) I guess it's how the other buttons work... I'll shut up! ;)

MKleusberg added a commit that referenced this issue Sep 10, 2017

Move button for saving Execute SQL results to the toolbar
In the Execute SQL tab, move the button for saving the results of a
query as either a CSV file or a view from the bottom of the results view
to the toolbar at the top.

See issue #1122.

@MKleusberg MKleusberg self-assigned this Sep 10, 2017

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Sep 10, 2017

I've tried to move the button to the toolbar 😉 Turns out this isn't as easy as it seems, so I've added this to the 3.11.0 milestone instead of the 3.10.1 one. It should mostly work the same as before with one small difference: if you execute some statement in tab 1, then change to tab 2, and back to tab 1, the button is disabled until you execute the statement again. I hope that's not causing too much of a problem 😉

@justinclift

This comment has been minimized.

Copy link
Member Author

justinclift commented Sep 10, 2017

Awesome, thanks @MKleusberg. Hopefully this does turn out better for new users, and doesn't inconvenience our existing ones. 😄

@chrisjlocke

This comment has been minimized.

Copy link
Contributor

chrisjlocke commented Sep 12, 2017

Just a nod that whenever you open a database or project, TAB 1 is created, regardless of whether one is there already or not. This is only repeated once (ie, you don't get more than 1 additional tab each time you open a database)

https://screencast-o-matic.com/watch/cbQl2kII93

@justinclift

This comment has been minimized.

Copy link
Member Author

justinclift commented Sep 12, 2017

Yeah, this is on purpose. It's so people don't lose their existing Execute SQL queries/results when closing a database. Looking quickly, #1035 seems to be the one. 😄

@chrisjlocke

This comment has been minimized.

Copy link
Contributor

chrisjlocke commented Sep 12, 2017

Aah, OK. Excellent! Well found! 🔎

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Sep 18, 2017

Can we close this issue? 😄

@justinclift

This comment has been minimized.

Copy link
Member Author

justinclift commented Sep 18, 2017

Testing it out now. 😄

@justinclift

This comment has been minimized.

Copy link
Member Author

justinclift commented Sep 18, 2017

Yep, this is working decently in testing here. Thanks @MKleusberg. 😄

if you execute some statement in tab 1, then change to tab 2, and back to tab 1, the button is disabled until you execute the statement again.

Is this something we should fix now (ie leave this open), or ignore until someone ask for it? 😄

It would be a matter of having some kind of event trigger when changing between tabs inside the Execute SQL er... tab, and enabling/disabling depending on whether there are results in the execute page for that tab. In theory that doesn't sound too complicated... but I'm not the person likely to implement it. (!) 😀

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Sep 18, 2017

I think I would leave it until somebody asks for it 😉 I think we would need to remember the execution status for each tab for this which shouldn't be too hard because it's mostly already saved in the table widget. But it's probably not worth the effort right now and I'll forget to add this anyway until somebody opens an issue for it 😆 So we might as well close this one now.

@justinclift

This comment has been minimized.

Copy link
Member Author

justinclift commented Sep 18, 2017

Cool. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment