Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upText should be also selectable in "read only" mode #1123
Comments
This comment has been minimized.
This comment has been minimized.
Ohhh yeah. That definitely makes sense. Thanks for reporting it @vlakoff, that should be pretty easy to fix. |
justinclift
added
the
bug
label
Sep 9, 2017
justinclift
added this to the 3.10.1 - Gaaah! milestone
Sep 9, 2017
added a commit
that referenced
this issue
Sep 10, 2017
This comment has been minimized.
This comment has been minimized.
This should work in tomorrow's nightly build. Are you ok to download that and test if it's working as expected, @vlakoff? |
This comment has been minimized.
This comment has been minimized.
Sure thing. Apparently it wasn't as trivial to fix as I was hoping. Will the textarea still be grayed out? |
This comment has been minimized.
This comment has been minimized.
No, the text area shouldn't be greyed out anymore in the new version The change is indeed a bit tricky but not that complicated. If you're interested I can explain a little |
This comment has been minimized.
This comment has been minimized.
I have tried it, at first glance it seems to work, I can select text using the mouse. (fwiw, the pane looks like the "non read-only mode": on first draw the pane has a white background and the text has a grey background, which disappears after I click in the pane) One caveat though: there is no blinking caret, so notably I can't select text using keyboard Shift + arrows. |
added a commit
that referenced
this issue
Sep 18, 2017
This comment has been minimized.
This comment has been minimized.
@MKleusberg Should we leave this open and look into the blinking caret thing, or close this? |
This comment has been minimized.
This comment has been minimized.
I think we can leave it open and see if we can do something about it. It looks like this is more a Qt issue than a DB4S one but maybe we can work around it somehow. But I haven't tried yet to be honest |
This comment has been minimized.
This comment has been minimized.
Just in case, I asked about it on Stack Overflow. |
This comment has been minimized.
This comment has been minimized.
@vlakoff Good thinking. If you're into IRC, asking on the Qt IRC channel is likely to get helpful info too. |
added a commit
that referenced
this issue
Dec 5, 2017
This comment has been minimized.
This comment has been minimized.
@vlakoff I've just applied the answer from Stack Overflow and it works as expected. If you want to take a look at the next nightly build: https://nightlies.sqlitebrowser.org/latest |
This comment has been minimized.
This comment has been minimized.
justinclift
added
the
response requested
label
Dec 6, 2017
This comment has been minimized.
This comment has been minimized.
It seems to work. Just a minor caveat: the caret doesn't blink Also, as discussed earlier, any chance the textarea background could be made grey again? |
This comment has been minimized.
This comment has been minimized.
I just found this forum thread: http://www.qtcentre.org/threads/39941-readonly-QTextEdit-with-visible-Cursor.
So, I guess the current solution is the best we can achieve, isn't it? |
added a commit
that referenced
this issue
Feb 3, 2018
This comment has been minimized.
This comment has been minimized.
@vlakoff I made a change for setting the same palette as the disabled state. It seems to affect only the selection and not the background, but that could be only in my environment. If you'd like to test it, it will be available in the next nightly build. I don't think that the non-bllinking caret is an issue. That would make me think that I can write, and that wouldn't be true. |
This comment has been minimized.
This comment has been minimized.
I have just tested it, and it seems to work as expected on Windows 7: the whole pane background is grey. As a reminder, previously I was seeing it as so:
|
This comment has been minimized.
This comment has been minimized.
Great to know. Then, can we close this issue? Or does anybody still think that the caret should blink? |
mgrojo
modified the milestones:
3.10.1 - Gaaah!,
3.11.0 - Where we take over the world! :D
Feb 5, 2018
This comment has been minimized.
This comment has been minimized.
I think it should be good enough. Text is now selectable, and background is grey, as previously. A handful of code has already been added to achieve this. Going further would be what I call "excess of quality". |
This comment has been minimized.
This comment has been minimized.
Ok, @vlakoff Thanks for your feedback. |
vlakoff commentedSep 9, 2017
I open a database in "read only" mode, then I select a cell. Its content is displayed in the "edit database cell" top right pane. The widget is read only (grayed out), but the text is not selectable, it would be convenient if it were :)