Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing in 'Table' textbox Generates 'PRAGMA foreign_keys' SQL #1130

Closed
3 of 14 tasks
chrisjlocke opened this issue Sep 12, 2017 · 5 comments
Closed
3 of 14 tasks

Typing in 'Table' textbox Generates 'PRAGMA foreign_keys' SQL #1130

chrisjlocke opened this issue Sep 12, 2017 · 5 comments
Labels

Comments

@chrisjlocke
Copy link
Contributor

@chrisjlocke chrisjlocke commented Sep 12, 2017

Details for the issue

More of a query than an issue, but mentinoing it in case it is an issue .... ;)
Every time a key is pressed in the 'Table' textbox of the 'Edit Table Definition' window, a log entry of 'PRAGMA foreign_keys' is logged. Just checking this is 'by design'....

image

Useful extra information

I'm opening this issue because:

  • DB4S is crashing
  • DB4S has a bug
  • DB4S needs a feature
  • DB4S has another problem

I'm using DB4S on:

  • Windows: ( version: ___ )
  • Linux: ( distro: ___ )
  • Mac OS: ( version: ___ )
  • Other: ___

I'm using DB4S version:

  • 3.10.0
  • 3.10.0-beta*
  • 3.9.1
  • Other: ___

I have also:

@justinclift
Copy link
Member

@justinclift justinclift commented Sep 12, 2017

Well spotted @chrisjlocke. Sounds more like a bug. 😄

@chrisjlocke
Copy link
Contributor Author

@chrisjlocke chrisjlocke commented Sep 12, 2017

I can never tell these days! ;)

MKleusberg added a commit that referenced this issue Oct 5, 2017
When changing the table name in the Edit Table dialog, don't query the
foreign key pragma for every key stroke.

See issue #1130.
@MKleusberg
Copy link
Member

@MKleusberg MKleusberg commented Oct 5, 2017

Heh heh, it's definitely more on the bug side of the the bug-feature continuum 😉 It should be fixed by the commit which I have just pushed. Are you ok to double check, @chrisjlocke?

@chrisjlocke
Copy link
Contributor Author

@chrisjlocke chrisjlocke commented Oct 6, 2017

Confirmed working. \o/
Thanks!

@chrisjlocke chrisjlocke closed this Oct 6, 2017
@MKleusberg
Copy link
Member

@MKleusberg MKleusberg commented Oct 6, 2017

Yay 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants