/sqlitebrowser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing in 'Table' textbox Generates 'PRAGMA foreign_keys' SQL #1130

Closed
chrisjlocke opened this Issue Sep 12, 2017 · 5 comments

Comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@chrisjlocke @justinclift @MKleusberg
@chrisjlocke
Copy link
Contributor

chrisjlocke commented Sep 12, 2017 •
edited

Details for the issue

More of a query than an issue, but mentinoing it in case it is an issue .... ;)
Every time a key is pressed in the 'Table' textbox of the 'Edit Table Definition' window, a log entry of 'PRAGMA foreign_keys' is logged. Just checking this is 'by design'....

image

Useful extra information

I'm opening this issue because:

  • DB4S is crashing
  • DB4S has a bug
  • DB4S needs a feature
  • DB4S has another problem

I'm using DB4S on:

  • Windows: ( version: ___ )
  • Linux: ( distro: ___ )
  • Mac OS: ( version: ___ )
  • Other: ___

I'm using DB4S version:

  • 3.10.0
  • 3.10.0-beta*
  • 3.9.1
  • Other: ___

I have also:
@justinclift

This comment has been minimized.

Sign in to view
Copy link
Member

justinclift commented Sep 12, 2017 •
edited

Well spotted @chrisjlocke. Sounds more like a bug. 😄

@justinclift justinclift added the bug label Sep 12, 2017

@chrisjlocke

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

chrisjlocke commented Sep 12, 2017

I can never tell these days! ;)

MKleusberg added a commit that referenced this issue Oct 5, 2017

@MKleusberg
Don't query foreign key settings repeatedly in Edit Table dialog 
When changing the table name in the Edit Table dialog, don't query the
foreign key pragma for every key stroke.

See issue #1130.
Loading status checks…
59b39bb
@MKleusberg

This comment has been minimized.

Sign in to view
Copy link
Member

MKleusberg commented Oct 5, 2017

Heh heh, it's definitely more on the bug side of the the bug-feature continuum 😉 It should be fixed by the commit which I have just pushed. Are you ok to double check, @chrisjlocke?
@chrisjlocke

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

chrisjlocke commented Oct 6, 2017 •
edited

Confirmed working. \o/
Thanks!

@chrisjlocke chrisjlocke closed this Oct 6, 2017

@MKleusberg

This comment has been minimized.

Sign in to view
Copy link
Member

MKleusberg commented Oct 6, 2017

Yay 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment