Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Attached Database Doesn't Attach If It Doesn't Contain Tables #1132
Details for the issue
Addmittedly an odd case, but I thought I'd report it.
* As an additional issue/suggestion, would DB4S be able to pre-populate the 'Enter a name for the database' textbox with the filename of the database you just attached (sans extension).
If a name isn't given for an attached database, DB4S assumes Cancel has been clicked, rather than inform the user that they can't enter nothing. Again, some warning might be handy. (or disable the OK box if the textbox is empty)
Sorry for multiple issues per issue (if that makes sense...) but I didn't want to stuff up the issues screen with related issues...
Useful extra information
I'm opening this issue because:
I'm using DB4S on:
I'm using DB4S version:
I have also:
Thanks, @chrisjlocke! These are all good ideas
I've just pushed a number of commits which should fix all problems mentioned in this issue: attaching empty databases should work fine now, the attach name dialog is now prepopulated, and an empty database name is not longer the same as clicking the cancel button.
SQLite is weird enough to allow empty names for attached database, so for now we allow it too even though it just doesn't look like a good idea to do that (but I'm sure, like it's always the case, there's somebody somewhere out there who actually uses this 'feature').
And yeah this is just stupid but as far as I remember SQLite allows empty table names and empty field names too. So this could execute just fine:
SELECT "" FROM ""."" WHERE ""="";
Edit: What a shame, it doesn't - at least not as expected