New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error using the cell editor #1138

Closed
Aermec opened this Issue Sep 13, 2017 · 7 comments

Comments

Projects
None yet
3 participants
@Aermec
Copy link

Aermec commented Sep 13, 2017

Details for the issue

If a text field starts with BMS word then the cell editor says 'Image data can't be viewed with the text editor'.
This bug comes out in the latest 3.10 and with 3.9.1 (I didn't try older versions).
I solved, for the moment, with another sqlite editor.

I'm opening this issue because:

  • DB4S is crashing
  • [ X] DB4S has a bug
  • DB4S needs a feature
  • DB4S has another problem

I'm using DB4S on:

  • [X ] Windows: ( version: ___ )
  • Linux: ( distro: ___ )
  • Mac OS: ( version: ___ )
  • Other: ___

I'm using DB4S version:

  • [X ] 3.10.0
  • 3.10.0-beta*
  • [X ] 3.9.1
  • Other: ___

screenshot

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Sep 13, 2017

Oh wow, nice catch @Aermec. Looks like the "data type detector" for the cell is getting caught out by that string. 😄

This could be a Qt bug in https://doc.qt.io/qt-5/qimagereader.html#canRead.

@justinclift justinclift added the bug label Sep 13, 2017

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Sep 22, 2017

Been trying to think of how we could detect this, without it getting too weird.

Instead, I'm thinking the best approach will be for us to file a bug on the Qt project against QImageReader::canRead(). That's returning "true" when it shouldn't be.

I'll file a bug report later on today, after I've switched to the computer with my Qt login info on it. 😄

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Sep 29, 2017

Bug report created on the Qt issue tracker: https://bugreports.qt.io/browse/QTBUG-63515

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Oct 2, 2017

As an update, the Qt developers have a proposed initial patch:

    https://codereview.qt-project.org/#/c/207418/1/src/gui/image/qbmphandler.cpp

That might be adjusted before it's accepted into Qt, but this is showing it's at least in progress. 😄

MKleusberg added a commit that referenced this issue Oct 5, 2017

Use a more sophisticated method for detecting image data in Edit dialog
In the Edit Data dialog we check if the data contained in a cell is an
image. This check returned some false positives, so this commit adds
another more sophisticated check to work around that.

See issue #1138 and #1159.
@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Oct 5, 2017

In the meantime I've added some easy code for mitigating this issue from our side.

Can you grab our next nightly build and check if it's working for you as expected using the new version, @Aermec? 😄

@Aermec

This comment has been minimized.

Copy link
Author

Aermec commented Oct 6, 2017

Hi,
I just tested the nightly build and it works! Thank you

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Oct 6, 2017

Cool 😄 Thanks for testing, @Aermec!

@MKleusberg MKleusberg closed this Oct 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment