Executing select "with recursion" marks database dirty

[pamtbaau]

Details for the issue

When a select with recursion is executed, the database is marked as dirty.

Useful extra information

I'm opening this issue because:

• DB4S is crashing
• DB4S has a bug
• DB4S needs a feature
• DB4S has another problem

I'm using DB4S on:

• Windows: ( version: 10 )
• Linux: ( distro: ___ )
• Mac OS: ( version: ___ )
• Other: ___

I'm using DB4S version:

• 3.10.1
• 3.10.0
• 3.9.1
• Other: 3.10.99

I have also:

• Tried out the latest nightly version: https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds
• Searched for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20

[MKleusberg]

Good point! I've prepared a patch for this which should fix this. It's replacing a wrong assumption by an untested one. If you want to have a look at this, you can check out this comment: #1181 (comment)

If there are no major concerns with this, we can merge the code in the next couple of days. I'll let you know as soon as this is done 😄

[MKleusberg]

And it's merged 😄 Can you test again using tomorrow's nightly build (hopefully the build works this time 😉)? It's also worth checking for any other oddities related to this, like what happens when running other statements.

[pamtbaau]

I would love to test, but again no nightlies for Windows 10 today....

[justinclift]

@pamtbaau Just started the nightlies build script manually ~5 mins ago, after @MKleusberg fixed the problem that was breaking it.

The now-very-overdue nighlies should be online in ~40 minutes if you're still wanting to test. Or just wait for tomorrows ones which should work ok too. 😄

[pamtbaau]

Tested build 3.10.99 (version doesn't get bumped anymore) from 29-Oct-2017 18:09 and a recursive query does not mark the database as dirty. Seems to be fixed.

[justinclift]

Fantastic. Thanks for verifying @pamtbaau. 😄