New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to rename tabs in sql panel and preserve names in project file #1186

Closed
pamtbaau opened this Issue Oct 22, 2017 · 16 comments

Comments

Projects
None yet
4 participants
@pamtbaau
Copy link

pamtbaau commented Oct 22, 2017

Details for the issue

It would be nice to be able to give tabs in the sql panel a descriptive name and preserve these names in the project file.

Useful extra information

I'm opening this issue because:

  • DB4S is crashing
  • DB4S has a bug
  • DB4S needs a feature
  • DB4S has another problem

I'm using DB4S on:

  • Windows: ( version: 10 )
  • Linux: ( distro: ___ )
  • Mac OS: ( version: ___ )
  • Other: ___

I'm using DB4S version:

  • 3.10.1
  • 3.10.0
  • 3.9.1
  • Other: 3.10.99

I have also:

MKleusberg added a commit that referenced this issue Oct 22, 2017

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Oct 22, 2017

This should be included in the next nightly build, too. You can now double click the title of an SQL tab and get a small dialog where you can change the name. The names are included in the project files as well and should be restored when loading a project file. Can you check that as well? 😄

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Oct 24, 2017

@MKleusberg I have been wanting to test this out the last few days, but I cannot find any nightlies since September 20th... Only nightly builds for OSX are refreshed every night.

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Oct 24, 2017

Thanks @pamtbaau. We haven't set up proactively monitoring for build failures yet, so yeah... that generally gets fixed when someone mentions it. 👼

Just added a potential fix, but haven't tested it yet as I don't have easy access to the Windows build VM right at the moment. If I don't get around to testing it before tomorrow, then we'll get to find out by checking if there's new Windows nightlies instead. 😄

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Oct 26, 2017

Still no nightlies for Windows 10/64 ....

@chrisjlocke

This comment has been minimized.

Copy link
Contributor

chrisjlocke commented Oct 27, 2017

We haven't set up proactively monitoring for build failures yet, so yeah... that generally gets fixed when someone mentions it.

Just slapped together a quick VB program that'll notify me if a nightly is missing.
I'll add into it a size check, as an issue ages ago meant one of the builds suddenly increased in size.

image

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Oct 27, 2017

Downloaded and tested... It works! Thank you so much for this feature.

@chrisjlocke

This comment has been minimized.

Copy link
Contributor

chrisjlocke commented Oct 27, 2017

Reopening it, as the & character isn't showing in Windows. (put a comment on the line in question)

image

@chrisjlocke chrisjlocke reopened this Oct 27, 2017

@MKleusberg

This comment has been minimized.

Copy link
Member

MKleusberg commented Oct 27, 2017

@pamtbaau Thanks again for testing 😉 Glad we could help!

@chrisjlocke Just pushed a fix for that. Can you check on tomorrow's nightly build if it's now working on Windows as expected?

@chrisjlocke

This comment has been minimized.

Copy link
Contributor

chrisjlocke commented Oct 29, 2017

image

Working great now. 👍

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Oct 29, 2017

Sorry to be a party pooper... It's not working on Windows 10. I can enter the ampersand in the popup, but it doesn't show on the tab. When showing the popup again, the ampersand shows...

Tested on the latest build 64 bit Windows 10 from 29-Oct-2017 18:09

@justinclift

This comment has been minimized.

Copy link
Member

justinclift commented Oct 29, 2017

No worries at all. This is exactly why we verify stuff manually before believing things are fixed. 😄

@chrisjlocke

This comment has been minimized.

Copy link
Contributor

chrisjlocke commented Oct 29, 2017

Do they show if you press the Alt key down?

Before I press Alt:

image

After:

image

This is probably a Qt thing, not a DB4S thing.

I know its a recent Windows thing that the accelerator underline 'hints' are hidden until the Alt key is pressed down

image

compared to when I hold down Alt:

image

For some reason (bug?) Qt isn't 'hiding' them again when Alt is released.

For the avoidance of doubt, regardless of whether the hints are showing, the accelerator still works, ie, pressing Alt+T (for my example) still shows the correct tab, and pressing Alt+R shows the other tab.

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Oct 30, 2017

A little mindbug on my part... It didn't occur to me that the '&' issue was about keyboard shortcuts and took it for "the & is not showing in the new name" (which it doesn't).

So, new findings:

  • The underscores do not appear before hitting Alt-key, but do after (as with Notepad)
  • The keyboard shortcut does work with Alt-key
  • To use '&' in the name, use '&&'
@chrisjlocke

This comment has been minimized.

Copy link
Contributor

chrisjlocke commented Oct 30, 2017

To use '&' in the name, use '&&'

Yes, I'll add this to the Wiki. As the '&' is used for an accelerator key (not technically a shortcut in the true sense... but who uses proper technical jargon anyway?) then && should be used to 'cancel' it out and display a '&' instead.

So are you OK closing this now?

@pamtbaau

This comment has been minimized.

Copy link
Author

pamtbaau commented Oct 30, 2017

I'm OK with it. I can name the tabs and as a bonus an accelerator key can be attached to it and '&' can be used in the name... What else could I ask for? :-)

@chrisjlocke

This comment has been minimized.

Copy link
Contributor

chrisjlocke commented Oct 30, 2017

Excellent, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment